Bump version to 4.0.14

Closes #7663

.github/workflows/build.yml

@@ -22,7 +22,7 @@ env:
   FRAMEWORK: net6.0
   RAW_BRANCH_NAME: ${{ github.head_ref || github.ref_name }}
   SONARR_MAJOR_VERSION: 4
-  VERSION: 4.0.12
+  VERSION: 4.0.14
 
 jobs:
   backend:

frontend/src/Components/Form/Select/EnhancedSelectInput.tsx

@@ -29,6 +29,8 @@ import HintedSelectInputOption from './HintedSelectInputOption';
 import HintedSelectInputSelectedValue from './HintedSelectInputSelectedValue';
 import styles from './EnhancedSelectInput.css';
 
+const MINIMUM_DISTANCE_FROM_EDGE = 10;
+
 function isArrowKey(keyCode: number) {
   return keyCode === keyCodes.UP_ARROW || keyCode === keyCodes.DOWN_ARROW;
 }
@@ -189,14 +191,9 @@ function EnhancedSelectInput<T extends EnhancedSelectInputValue<V>, V>(
 
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const handleComputeMaxHeight = useCallback((data: any) => {
-    const { top, bottom } = data.offsets.reference;
     const windowHeight = window.innerHeight;
 
-    if (/^bottom/.test(data.placement)) {
-      data.styles.maxHeight = windowHeight - bottom;
-    } else {
-      data.styles.maxHeight = top;
-    }
+    data.styles.maxHeight = windowHeight - MINIMUM_DISTANCE_FROM_EDGE;
 
     return data;
   }, []);
@@ -508,6 +505,10 @@ function EnhancedSelectInput<T extends EnhancedSelectInputValue<V>, V>(
                 enabled: true,
                 fn: handleComputeMaxHeight,
               },
+              preventOverflow: {
+                enabled: true,
+                boundariesElement: 'viewport',
+              },
             }}
           >
             {({ ref, style, scheduleUpdate }) => {

src/NzbDrone.Core/Download/RejectedImportService.cs

@@ -1,5 +1,5 @@
-using System.Collections.Generic;
 using System.Linq;
+using NLog;
 using NzbDrone.Core.Download.TrackedDownloads;
 using NzbDrone.Core.Indexers;
 using NzbDrone.Core.MediaFiles.EpisodeImport;
@@ -14,15 +14,17 @@ public interface IRejectedImportService
 public class RejectedImportService : IRejectedImportService
 {
     private readonly ICachedIndexerSettingsProvider _cachedIndexerSettingsProvider;
+    private readonly Logger _logger;
 
-    public RejectedImportService(ICachedIndexerSettingsProvider cachedIndexerSettingsProvider)
+    public RejectedImportService(ICachedIndexerSettingsProvider cachedIndexerSettingsProvider, Logger logger)
     {
         _cachedIndexerSettingsProvider = cachedIndexerSettingsProvider;
+        _logger = logger;
     }
 
     public bool Process(TrackedDownload trackedDownload, ImportResult importResult)
     {
-        if (importResult.Result != ImportResultType.Rejected || importResult.ImportDecision.LocalEpisode == null)
+        if (importResult.Result != ImportResultType.Rejected || trackedDownload.RemoteEpisode?.Release == null)
         {
             return false;
         }
@@ -30,19 +32,27 @@ public class RejectedImportService : IRejectedImportService
         var indexerSettings = _cachedIndexerSettingsProvider.GetSettings(trackedDownload.RemoteEpisode.Release.IndexerId);
         var rejectionReason = importResult.ImportDecision.Rejections.FirstOrDefault()?.Reason;
 
+        if (indexerSettings == null)
+        {
+            trackedDownload.Warn(new TrackedDownloadStatusMessage(trackedDownload.DownloadItem.Title, importResult.Errors));
+            return true;
+        }
+
         if (rejectionReason == ImportRejectionReason.DangerousFile &&
             indexerSettings.FailDownloads.Contains(FailDownloads.PotentiallyDangerous))
         {
+            _logger.Trace("Download '{0}' contains potentially dangerous file, marking as failed", trackedDownload.DownloadItem.Title);
             trackedDownload.Fail();
         }
         else if (rejectionReason == ImportRejectionReason.ExecutableFile &&
             indexerSettings.FailDownloads.Contains(FailDownloads.Executables))
         {
+            _logger.Trace("Download '{0}' contains executable file, marking as failed", trackedDownload.DownloadItem.Title);
             trackedDownload.Fail();
         }
         else
         {
-            trackedDownload.Warn(new TrackedDownloadStatusMessage(importResult.Errors.First(), new List<string>()));
+            trackedDownload.Warn(new TrackedDownloadStatusMessage(trackedDownload.DownloadItem.Title, importResult.Errors));
         }
 
         return true;

src/NzbDrone.Core/Download/TrackedDownloads/TrackedDownload.cs

@@ -40,6 +40,9 @@ namespace NzbDrone.Core.Download.TrackedDownloads
         {
             Status = TrackedDownloadStatus.Error;
             State = TrackedDownloadState.FailedPending;
+
+            // Set CanBeRemoved to allow the failed item to be removed from the client
+            DownloadItem.CanBeRemoved = true;
         }
     }
 

src/NzbDrone.Core/Localization/Core/da.json

@@ -103,5 +103,20 @@
     "DeleteReleaseProfileMessageText": "Er du sikker på, at du vil slette udgivelsesprofilen »{name}«?",
     "MinutesSixty": "60 minutter: {sixty}",
     "NegateHelpText": "Hvis dette er markeret, gælder det tilpassede format ikke, hvis denne {implementationName}-betingelse stemmer overens.",
-    "RemoveSelectedItemsQueueMessageText": "Er du sikker på, at du vil fjerne {selectedCount} elementer fra køen?"
+    "RemoveSelectedItemsQueueMessageText": "Er du sikker på, at du vil fjerne {selectedCount} elementer fra køen?",
+    "AddNewSeriesSearchForCutoffUnmetEpisodes": "Start søgning efter uopfyldte cutoff epsioder",
+    "AddNewSeriesRootFolderHelpText": "'{folder}' undermappen vil blive oprettet automatisk",
+    "AddNewSeriesSearchForMissingEpisodes": "Start søgning efter manglende episoder",
+    "AddListExclusionSeriesHelpText": "Forhindre serie fra at blive tilføjet til {appName} af lister",
+    "AddQualityProfile": "Tilføj Kvalitetsprofil",
+    "AddReleaseProfile": "Tilføj udgivelsesprofil",
+    "AddNewSeriesError": "Kunne ikke indlæse søgeresultater, prøv igen.",
+    "AddNewSeriesHelpText": "Det er nemt at tilføje en ny serie, bare start med at skrive navnet på serien du gerne vil tilføje.",
+    "AddQualityProfileError": "Kunne ikke tilføje ny kvalitetsprofil, prøv igen.",
+    "AddListExclusionError": "Kunne ikke tilføje den nye liste eksklusion, prøv igen.",
+    "AddNewRestriction": "Tilføj ny restriktion",
+    "AddNotificationError": "Kunne ikke tilføje ny notifikation, prøv igen.",
+    "AddRemotePathMapping": "Tilføj Sammenkædning med fjernsti",
+    "AddNew": "Tilføj ny",
+    "AddNewSeries": "Tilføj ny serie"
 }

src/NzbDrone.Core/Localization/Core/fi.json

@@ -1455,7 +1455,7 @@
     "HealthMessagesInfoBox": "Saat lisätietoja näiden vakausviestien syistä painamalla rivin lopussa olevaa wikilinkkiä (kirjakuvake) tai tarkastelemalla [lokitietoja]({link}). Mikäli et osaa tulkita näitä viestejä, tavoitat tukemme alla olevilla linkeillä.",
     "MegabytesPerMinute": "Megatavua minuutissa",
     "MustContain": "Täytyy sisältää",
-    "NoLinks": "Linkkejä ei ole",
+    "NoLinks": "Kytköksiä ei ole",
     "Proxy": "Välityspalvelin",
     "ProxyUsernameHelpText": "Käyttäjätunnus ja salasana tulee täyttää vain tarvittaessa. Mikäli näitä ei ole, tulee kentät jättää tyhjiksi.",
     "ImportListsSettingsSummary": "Sisällön tuonti muista {appName}-instansseista tai palveluista, ja poikkeuslistojen hallinta.",

src/NzbDrone.Core/MediaFiles/FileExtensions.cs

@@ -23,7 +23,9 @@ namespace NzbDrone.Core.MediaFiles
 
         private static List<string> _dangerousExtensions = new List<string>
         {
+            ".arj",
             ".lnk",
+            ".lzh",
             ".ps1",
             ".scr",
             ".vbs",

src/NzbDrone.Core/Sonarr.Core.csproj

@@ -20,7 +20,7 @@
     <PackageReference Include="Servarr.FluentMigrator.Runner.SQLite" Version="3.3.2.9" />
     <PackageReference Include="Servarr.FluentMigrator.Runner.Postgres" Version="3.3.2.9" />
     <PackageReference Include="FluentValidation" Version="9.5.4" />
-    <PackageReference Include="SixLabors.ImageSharp" Version="3.1.6" />
+    <PackageReference Include="SixLabors.ImageSharp" Version="3.1.7" />
     <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
     <PackageReference Include="NLog" Version="5.3.4" />
     <PackageReference Include="MonoTorrent" Version="2.0.7" />