tedkulp/Readarr
1
0
Fork 0
mirror of https://github.com/Readarr/Readarr.git synced 2026-03-05 13:20:32 -05:00
Code Issues Projects Releases Wiki Activity

Fixed: Null reference error when import list adds new book to existing author

Browse Source 
Fixes #1235

(cherry picked from commit 5e3045db86748d0ab407a6785007cb6bbd4f46a6)
This commit is contained in:
Thomas White
2021-09-19 23:02:45 +08:00
committed by ta264
parent 859dd091f3
commit 294346db35
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/NzbDrone.Core.Test/ImportListTests/ImportListSyncServiceFixture.cs
View File

@@ -105,14 +105,14 @@ namespace NzbDrone.Core.Test.ImportListTests
{
Mocker.GetMock<IAuthorService>()
.Setup(v => v.FindById(_importListReports.First().AuthorGoodreadsId))
.Returns(new Author { ForeignAuthorId = _importListReports.First().AuthorGoodreadsId });
.Returns(new Author { Id = 1, ForeignAuthorId = _importListReports.First().AuthorGoodreadsId });
}
private void WithExistingBook()
{
Mocker.GetMock<IBookService>()
.Setup(v => v.FindById(_importListReports.First().EditionGoodreadsId))
.Returns(new Book { ForeignBookId = _importListReports.First().EditionGoodreadsId });
.Returns(new Book { Id = 1, ForeignBookId = _importListReports.First().EditionGoodreadsId });
}
private void WithExcludedAuthor()
@@ -231,6 +231,7 @@ namespace NzbDrone.Core.Test.ImportListTests
public void should_add_if_existing_author_but_new_book()
{
WithBookId();
WithAuthorId();
WithExistingAuthor();
Subject.Execute(new ImportListSyncCommand());

4
src/NzbDrone.Core/ImportLists/ImportListSyncService.cs
View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using NLog;
using NzbDrone.Common.Extensions;
@@ -262,8 +263,9 @@ namespace NzbDrone.Core.ImportLists
}
};
if (importList.ShouldMonitor == ImportListMonitorType.SpecificBook)
if (importList.ShouldMonitor == ImportListMonitorType.SpecificBook && toAddAuthor.AddOptions != null)
{
Debug.Assert(toAddAuthor.Id == 0, "new author added but ID is not 0");
toAddAuthor.AddOptions.BooksToMonitor.Add(toAdd.ForeignBookId);
}