Fixed: SABnzbd history retention to allow at least 14 days

(cherry picked from commit a3938d8e0264b48b35f4715cbc15329fb489218a)

Closes #9217

azure-pipelines.yml

@@ -9,7 +9,7 @@ variables:
   testsFolder: './_tests'
   yarnCacheFolder: $(Pipeline.Workspace)/.yarn
   nugetCacheFolder: $(Pipeline.Workspace)/.nuget/packages
-  majorVersion: '5.0.2'
+  majorVersion: '5.0.3'
   minorVersion: $[counter('minorVersion', 2000)]
   radarrVersion: '$(majorVersion).$(minorVersion)'
   buildName: '$(Build.SourceBranchName).$(radarrVersion)'

src/NzbDrone.Core.Test/Download/DownloadClientTests/SabnzbdTests/SabnzbdFixture.cs

@@ -452,6 +452,30 @@ namespace NzbDrone.Core.Test.Download.DownloadClientTests.SabnzbdTests
             result.OutputRootFolders.First().Should().Be(fullCategoryDir);
         }
 
+        [TestCase("0")]
+        [TestCase("15d")]
+        public void should_set_history_removes_completed_downloads_false(string historyRetention)
+        {
+            _config.Misc.history_retention = historyRetention;
+
+            var downloadClientInfo = Subject.GetStatus();
+
+            downloadClientInfo.RemovesCompletedDownloads.Should().BeFalse();
+        }
+
+        [TestCase("-1")]
+        [TestCase("15")]
+        [TestCase("3")]
+        [TestCase("3d")]
+        public void should_set_history_removes_completed_downloads_true(string historyRetention)
+        {
+            _config.Misc.history_retention = historyRetention;
+
+            var downloadClientInfo = Subject.GetStatus();
+
+            downloadClientInfo.RemovesCompletedDownloads.Should().BeTrue();
+        }
+
         [TestCase(@"Y:\sabnzbd\root", @"completed\downloads", @"vv", @"Y:\sabnzbd\root\completed\downloads", @"Y:\sabnzbd\root\completed\downloads\vv")]
         [TestCase(@"Y:\sabnzbd\root", @"completed", @"vv", @"Y:\sabnzbd\root\completed", @"Y:\sabnzbd\root\completed\vv")]
         [TestCase(@"/sabnzbd/root", @"completed/downloads", @"vv", @"/sabnzbd/root/completed/downloads", @"/sabnzbd/root/completed/downloads/vv")]

src/NzbDrone.Core/Download/Clients/Sabnzbd/Sabnzbd.cs

@@ -278,7 +278,16 @@ namespace NzbDrone.Core.Download.Clients.Sabnzbd
                 status.OutputRootFolders = new List<OsPath> { _remotePathMappingService.RemapRemoteToLocal(Settings.Host, category.FullPath) };
             }
 
-            status.RemovesCompletedDownloads = config.Misc.history_retention != "0";
+            if (config.Misc.history_retention.IsNotNullOrWhiteSpace() && config.Misc.history_retention.EndsWith("d"))
+            {
+                int.TryParse(config.Misc.history_retention.AsSpan(0, config.Misc.history_retention.Length - 1),
+                    out var daysRetention);
+                status.RemovesCompletedDownloads = daysRetention < 14;
+            }
+            else
+            {
+                status.RemovesCompletedDownloads = config.Misc.history_retention != "0";
+            }
 
             return status;
         }

src/NzbDrone.Core/Localization/Core/it.json

@@ -1079,5 +1079,6 @@
     "ApplyChanges": "Applica Cambiamenti",
     "AutomaticAdd": "Aggiungi Automaticamente",
     "AllTitles": "Tutti i Titoli",
-    "ApiKeyValidationHealthCheckMessage": "Aggiorna la tua chiave API in modo che abbia una lunghezza di almeno {0} caratteri. Puoi farlo dalle impostazioni o dal file di configurazione"
+    "ApiKeyValidationHealthCheckMessage": "Aggiorna la tua chiave API in modo che abbia una lunghezza di almeno {0} caratteri. Puoi farlo dalle impostazioni o dal file di configurazione",
+    "AddImportList": "Aggiungi lista da importare"
 }

src/NzbDrone.Core/Localization/Core/nl.json

@@ -1125,5 +1125,8 @@
     "AddAutoTag": "Voeg Automatische Tag toe",
     "AddCondition": "Voeg Conditie toe",
     "AutoTagging": "Automatisch Taggen",
-    "CloneAutoTag": "Kopieer Automatische Tag"
+    "CloneAutoTag": "Kopieer Automatische Tag",
+    "AddConditionImplementation": "Voeg voorwaarde toe - {implementationName}",
+    "AddConnection": "Voeg connectie toe",
+    "AddConnectionImplementation": "Voeg connectie toe - {implementationName}"
 }

src/NzbDrone.Core/Localization/Core/pt_BR.json

@@ -629,7 +629,7 @@
     "SomeResultsHiddenFilter": "Alguns resultados estão ocultos pelo filtro aplicado",
     "Socks5": "Socks5 (Suporte à TOR)",
     "Small": "Pequeno",
-    "SkipFreeSpaceCheckWhenImportingHelpText": "Use quando o Radarr não conseguir detectar espaço livre na pasta raiz do filme",
+    "SkipFreeSpaceCheckWhenImportingHelpText": "Use quando o Radarr não conseguir detectar espaço livre em sua pasta raiz durante a importação do arquivo",
     "SkipFreeSpaceCheck": "Ignorar verificação de espaço livre",
     "SizeOnDisk": "Tamanho em disco",
     "Size": "Tamanho",
@@ -1328,5 +1328,6 @@
     "OrganizeNamingPattern": "Padrão de nomenclatura: `{standardMovieFormat}`",
     "OrganizeNothingToRename": "Sucesso! Meu trabalho está concluído, não há arquivos para renomear.",
     "OrganizeRelativePaths": "Todos os caminhos são relativos a: `{path}`",
-    "OrganizeRenamingDisabled": "A renomeação está desativada, nada para renomear"
+    "OrganizeRenamingDisabled": "A renomeação está desativada, nada para renomear",
+    "DownloadClientRemovesCompletedDownloadsHealthCheckMessage": "O cliente de download {0} está configurado para remover downloads concluídos. Isso pode resultar na remoção dos downloads do seu cliente antes que {1} possa importá-los."
 }

src/NzbDrone.Core/Localization/Core/zh_CN.json

@@ -690,7 +690,7 @@
     "UnableToAddANewNotificationPleaseTryAgain": "无法添加新通知，请稍后重试。",
     "URLBase": "基本URL",
     "RemovedMovieCheckMultipleMessage": "电影“{0}”已从TMDb移除",
-    "SkipFreeSpaceCheckWhenImportingHelpText": "当 Radarr 无法从movie根目录检测到空间时使用",
+    "SkipFreeSpaceCheckWhenImportingHelpText": "当Radarr无法在文件导入期间检测到根文件夹的空闲空间时使用",
     "UnableToAddANewQualityProfilePleaseTryAgain": "无法添加新的质量配置，请稍后重试。",
     "ThisCannotBeCancelled": "在不禁用所有索引器的情况下，一旦启动就无法取消。",
     "SearchCutoffUnmet": "搜索未满足终止条件的",
@@ -1329,5 +1329,6 @@
     "UnableToLoadAutoTagging": "无法加载自动标记",
     "OverrideGrabNoMovie": "必须选择电影",
     "RetryingDownloadOn": "于 {date} {time} 重试下载",
-    "Or": "或"
+    "Or": "或",
+    "DownloadClientRemovesCompletedDownloadsHealthCheckMessage": "下载客户端{0}设置为删除已完成的下载。这可能导致在{1}可以导入下载之前从您的客户端删除下载。"
 }