Fixed: Migrate (Newznab) nzb.su to nzb.life

Co-authored-by: Stevie<stevie.robinson@gmail.com>

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -4,18 +4,11 @@ labels: ['Type: Bug', 'Status: Needs Triage']
 body:
 - type: checkboxes
   attributes:
-    label: I attest that there is not an existing issue for this?
+    label: Is there an existing issue for this?
     description: Please search to see if an open or closed issue already exists for the bug you encountered. If a bug exists and is closed note that it may only be fixed in an unstable branch.
     options:
     - label: I have searched the existing open and closed issues
       required: true
-- type: checkboxes
-  attributes:
-    label: I attest this is not related to a Cardigann YML Indexer.
-    description: Please search to see if this is for a tracker [that is yml-based (Cardigann)](https://github.com/Prowlarr/indexers) these are synced to Prowlarr/Indexers from Jackett/Jackett.
-    options:
-    - label: I confirm this is not related to a Cardigann YML Indexer
-      required: true
 - type: textarea
   attributes:
     label: Current Behavior
@@ -80,8 +73,8 @@ body:
     required: true
 - type: checkboxes
   attributes:
-    label: I attest that Trace Logs have been provided as applicable. Reports will be closed if the required logs are not provided.
+    label: Trace Logs have been provided as applicable. Reports may be closed if the required logs are not provided.
     description: Trace logs are generally required for all bug reports and contain `trace`. Info logs are invalid for bug reports and do not contain `debug` nor `trace`
     options:
-    - label: I attest that I have read and followed the steps in the wiki link above and provided the required trace logs - the logs contain `trace` - that are relevant and show this issue.
+    - label: I have read and followed the steps in the wiki link above and provided the required trace logs - the logs contain `trace` - that are relevant and show this issue.
       required: true

azure-pipelines.yml

@@ -9,7 +9,7 @@ variables:
   testsFolder: './_tests'
   yarnCacheFolder: $(Pipeline.Workspace)/.yarn
   nugetCacheFolder: $(Pipeline.Workspace)/.nuget/packages
-  majorVersion: '2.1.2'
+  majorVersion: '2.1.0'
   minorVersion: $[counter('minorVersion', 1)]
   prowlarrVersion: '$(majorVersion).$(minorVersion)'
   buildName: '$(Build.SourceBranchName).$(prowlarrVersion)'

src/NzbDrone.Core.Test/Datastore/Migration/044_nzb_su_url_to_nzb_lifeFixture.cs

@@ -0,0 +1,88 @@
+using System.Collections.Generic;
+using System.Linq;
+using FluentAssertions;
+using Newtonsoft.Json.Linq;
+using NUnit.Framework;
+using NzbDrone.Common.Serializer;
+using NzbDrone.Core.Datastore.Migration;
+using NzbDrone.Core.Test.Framework;
+
+namespace NzbDrone.Core.Test.Datastore.Migration
+{
+    [TestFixture]
+    public class nzb_su_url_to_nzb_lifeFixture : MigrationTest<nzb_su_url_to_nzb_life>
+    {
+        [TestCase("Newznab", "https://api.nzb.su")]
+        [TestCase("Newznab", "http://api.nzb.su")]
+        public void should_replace_old_url(string impl, string baseUrl)
+        {
+            var db = WithMigrationTestDb(c =>
+            {
+                c.Insert.IntoTable("Indexers").Row(new
+                {
+                    Name = "Nzb.su",
+                    Implementation = impl,
+                    Settings = new NewznabSettings044
+                    {
+                        BaseUrl = baseUrl,
+                        ApiPath = "/api"
+                    }.ToJson(),
+                    ConfigContract = impl + "Settings",
+                    EnableInteractiveSearch = false
+                });
+            });
+
+            var items = db.Query<IndexerDefinition044>("SELECT * FROM \"Indexers\"");
+
+            items.Should().HaveCount(1);
+            items.First().Settings.ToObject<NewznabSettings044>().BaseUrl.Should().Be(baseUrl.Replace("su", "life"));
+        }
+
+        [TestCase("Newznab", "https://api.indexer.com")]
+        public void should_not_replace_different_url(string impl, string baseUrl)
+        {
+            var db = WithMigrationTestDb(c =>
+            {
+                c.Insert.IntoTable("Indexers").Row(new
+                {
+                    Name = "Indexer.com",
+                    Implementation = impl,
+                    Settings = new NewznabSettings044
+                    {
+                        BaseUrl = baseUrl,
+                        ApiPath = "/api"
+                    }.ToJson(),
+                    ConfigContract = impl + "Settings",
+                    EnableInteractiveSearch = false
+                });
+            });
+
+            var items = db.Query<IndexerDefinition044>("SELECT * FROM \"Indexers\"");
+
+            items.Should().HaveCount(1);
+            items.First().Settings.ToObject<NewznabSettings044>().BaseUrl.Should().Be(baseUrl);
+        }
+    }
+
+    internal class IndexerDefinition044
+    {
+        public int Id { get; set; }
+        public string Name { get; set; }
+        public JObject Settings { get; set; }
+        public int Priority { get; set; }
+        public string Implementation { get; set; }
+        public string ConfigContract { get; set; }
+        public bool EnableRss { get; set; }
+        public bool EnableAutomaticSearch { get; set; }
+        public bool EnableInteractiveSearch { get; set; }
+        public HashSet<int> Tags { get; set; }
+        public int DownloadClientId { get; set; }
+        public int SeasonSearchMaximumSingleEpisodeAge { get; set; }
+    }
+
+    internal class NewznabSettings044
+    {
+        public string BaseUrl { get; set; }
+        public string ApiPath { get; set; }
+    }
+}

src/NzbDrone.Core.Test/IndexerTests/BroadcastheNetTests/BroadcastheNetRequestGeneratorFixture.cs

@@ -140,7 +140,7 @@ namespace NzbDrone.Core.Test.IndexerTests.BroadcastheNetTests
             query.Tvrage.Should().BeNull();
             query.Search.Should().BeNull();
             query.Category.Should().Be("Episode");
-            query.Name.Should().Be("2023.01.03%");
+            query.Name.Should().Be("2023.01.03");
         }
 
         [Test]
@@ -275,7 +275,7 @@ namespace NzbDrone.Core.Test.IndexerTests.BroadcastheNetTests
             query.Tvrage.Should().BeNull();
             query.Search.Should().Be("The%Late%Show%with%Stephen%Colbert");
             query.Category.Should().Be("Episode");
-            query.Name.Should().Be("2023.01.03%");
+            query.Name.Should().Be("2023.01.03");
         }
 
         private static BroadcastheNetTorrentQuery ParseTorrentQueryFromRequest(HttpRequest httpRequest)

src/NzbDrone.Core/Datastore/Migration/044_nzb_su_url_to_nzb_life.cs

@@ -0,0 +1,16 @@
+using FluentMigrator;
+using NzbDrone.Core.Datastore.Migration.Framework;
+
+namespace NzbDrone.Core.Datastore.Migration
+{
+    [Migration(044)]
+    public class nzb_su_url_to_nzb_life : NzbDroneMigrationBase
+    {
+        protected override void MainDbUpgrade()
+        {
+            Execute.Sql("UPDATE \"Indexers\" SET \"Settings\" = replace(\"Settings\", '//api.nzb.su', '//api.nzb.life')" +
+                        "WHERE \"Implementation\" = 'Newznab'" +
+                        "AND \"Settings\" LIKE '%//api.nzb.su%'");
+        }
+    }
+}

src/NzbDrone.Core/Indexers/Definitions/BroadcastheNet/BroadcastheNetRequestGenerator.cs

@@ -74,7 +74,7 @@ namespace NzbDrone.Core.Indexers.BroadcastheNet
             else if (DateTime.TryParseExact($"{searchCriteria.Season} {searchCriteria.Episode}", "yyyy MM/dd", CultureInfo.InvariantCulture, DateTimeStyles.None, out var showDate))
             {
                 // Daily Episode
-                parameters.Name = showDate.ToString("yyyy.MM.dd", CultureInfo.InvariantCulture) + "%";
+                parameters.Name = showDate.ToString("yyyy.MM.dd", CultureInfo.InvariantCulture);
                 parameters.Category = "Episode";
                 pageableRequests.Add(GetPagedRequests(parameters, btnResults, btnOffset));
             }