Fixed: Don't allow pushed releases to bypass pending releases that recently expired

Closes #7725
2026-04-25 22:46:31 -04:00 · 2025-03-23 18:11:24 -07:00
parent 83b2c9e97a
commit da29de4cfe
72 changed files with 632 additions and 369 deletions
@@ -0,0 +1,54 @@
+using System.Linq;
+using NLog;
+using NzbDrone.Core.Download.Pending;
+using NzbDrone.Core.Parser.Model;
+
+namespace NzbDrone.Core.DecisionEngine.Specifications.RssSync
+{
+    public class PendingSpecification : IDownloadDecisionEngineSpecification
+    {
+        private readonly IPendingReleaseService _pendingReleaseService;
+        private readonly Logger _logger;
+
+        public PendingSpecification(IPendingReleaseService pendingReleaseService,
+                                  Logger logger)
+        {
+            _pendingReleaseService = pendingReleaseService;
+            _logger = logger;
+        }
+
+        public SpecificationPriority Priority => SpecificationPriority.Database;
+        public RejectionType Type => RejectionType.Temporary;
+
+        public DownloadSpecDecision IsSatisfiedBy(RemoteEpisode subject, ReleaseDecisionInformation information)
+        {
+            // Skip this check for RSS sync and interactive searches,
+
+            if (subject.ReleaseSource == ReleaseSourceType.Rss)
+            {
+                return DownloadSpecDecision.Accept();
+            }
+
+            if (information.SearchCriteria is { UserInvokedSearch: true })
+            {
+                _logger.Debug("Ignoring delay for user invoked search");
+                return DownloadSpecDecision.Accept();
+            }
+
+            var pending = _pendingReleaseService.GetPendingQueue();
+
+            var matchingEpisode = pending.Where(q => q.RemoteEpisode?.Series != null &&
+                                                     q.RemoteEpisode.Series.Id == subject.Series.Id &&
+                                                     q.RemoteEpisode.Episodes.Select(e => e.Id).Intersect(subject.Episodes.Select(e => e.Id)).Any())
+                                       .ToList();
+
+            if (matchingEpisode.Any())
+            {
+                _logger.Debug("Release containing at least one matching episode is already pending. Delaying pushed release");
+                return DownloadSpecDecision.Reject(DownloadRejectionReason.MinimumAgeDelayPushed, "Release containing at least one matching episode is already pending, delaying pushed release");
+            }
+
+            return DownloadSpecDecision.Accept();
+        }
+    }
+}