tedkulp/Readarr
1
0
Fork 0
mirror of https://github.com/Readarr/Readarr.git synced 2026-04-24 22:35:39 -04:00
Code Issues Projects Releases Wiki Activity

StyleCop (#1058)

Browse Source 
* Stylecop Rules and Fixes
This commit is contained in:
Qstick
2020-01-03 07:49:24 -05:00
committed by GitHub
parent 63d669178d
commit f77a2feeef
1307 changed files with 8704 additions and 7404 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/NzbDrone.Core.Test/ImportListTests/ImportListServiceFixture.cs
+1 -1
View File
@@ -31,7 +31,7 @@ namespace NzbDrone.Core.Test.ImportListTests
Mocker.SetConstant<IImportListRepository>(repo);
var existingImportLists = Builder<ImportListDefinition>.CreateNew().BuildNew();
existingImportLists.ConfigContract = typeof (LidarrListsSettings).Name;
existingImportLists.ConfigContract = typeof(LidarrListsSettings).Name;
repo.Insert(existingImportLists);
src/NzbDrone.Core.Test/ImportListTests/ImportListSyncServiceFixture.cs
+18 -15
View File
@@ -1,13 +1,13 @@
using System.Linq;
using System.Collections.Generic;
using System.Linq;
using Moq;
using NUnit.Framework;
using NzbDrone.Core.ImportLists;
using NzbDrone.Core.ImportLists.Exclusions;
using NzbDrone.Core.MetadataSource;
using NzbDrone.Core.Music;
using NzbDrone.Core.Parser.Model;
using NzbDrone.Core.Test.Framework;
using NzbDrone.Core.ImportLists.Exclusions;
namespace NzbDrone.Core.Test.ImportListTests
{
@@ -23,7 +23,7 @@ namespace NzbDrone.Core.Test.ImportListTests
Artist = "Linkin Park"
};
_importListReports = new List<ImportListItemInfo>{importListItem1};
_importListReports = new List<ImportListItemInfo> { importListItem1 };
Mocker.GetMock<IFetchAndParseImportList>()
.Setup(v => v.Fetch())
@@ -39,7 +39,7 @@ namespace NzbDrone.Core.Test.ImportListTests
Mocker.GetMock<IImportListFactory>()
.Setup(v => v.Get(It.IsAny<int>()))
.Returns(new ImportListDefinition{ ShouldMonitor = ImportListMonitorType.SpecificAlbum });
.Returns(new ImportListDefinition { ShouldMonitor = ImportListMonitorType.SpecificAlbum });
Mocker.GetMock<IFetchAndParseImportList>()
.Setup(v => v.Fetch())
@@ -69,22 +69,24 @@ namespace NzbDrone.Core.Test.ImportListTests
{
Mocker.GetMock<IArtistService>()
.Setup(v => v.FindById(_importListReports.First().ArtistMusicBrainzId))
.Returns(new Artist{ForeignArtistId = _importListReports.First().ArtistMusicBrainzId });
.Returns(new Artist { ForeignArtistId = _importListReports.First().ArtistMusicBrainzId });
}
private void WithExistingAlbum()
{
Mocker.GetMock<IAlbumService>()
.Setup(v => v.FindById(_importListReports.First().AlbumMusicBrainzId))
.Returns(new Album{ForeignAlbumId = _importListReports.First().AlbumMusicBrainzId });
.Returns(new Album { ForeignAlbumId = _importListReports.First().AlbumMusicBrainzId });
}
private void WithExcludedArtist()
{
Mocker.GetMock<IImportListExclusionService>()
.Setup(v => v.All())
.Returns(new List<ImportListExclusion> {
new ImportListExclusion {
.Returns(new List<ImportListExclusion>
{
new ImportListExclusion
{
ForeignId = "f59c5520-5f46-4d2c-b2c4-822eabf53419"
}
});
@@ -94,8 +96,10 @@ namespace NzbDrone.Core.Test.ImportListTests
{
Mocker.GetMock<IImportListExclusionService>()
.Setup(v => v.All())
.Returns(new List<ImportListExclusion> {
new ImportListExclusion {
.Returns(new List<ImportListExclusion>
{
new ImportListExclusion
{
ForeignId = "09474d62-17dd-3a4f-98fb-04c65f38a479"
}
});
@@ -105,7 +109,7 @@ namespace NzbDrone.Core.Test.ImportListTests
{
Mocker.GetMock<IImportListFactory>()
.Setup(v => v.Get(It.IsAny<int>()))
.Returns(new ImportListDefinition{ ShouldMonitor = monitor });
.Returns(new ImportListDefinition { ShouldMonitor = monitor });
}
[Test]
@@ -172,7 +176,7 @@ namespace NzbDrone.Core.Test.ImportListTests
Subject.Execute(new ImportListSyncCommand());
Mocker.GetMock<IAddArtistService>()
.Verify(v => v.AddArtists(It.Is<List<Artist>>(t=>t.Count == 0)));
.Verify(v => v.AddArtists(It.Is<List<Artist>>(t => t.Count == 0)));
}
[Test]
@@ -184,7 +188,7 @@ namespace NzbDrone.Core.Test.ImportListTests
Subject.Execute(new ImportListSyncCommand());
Mocker.GetMock<IAddArtistService>()
.Verify(v => v.AddArtists(It.Is<List<Artist>>(t=>t.Count == 0)));
.Verify(v => v.AddArtists(It.Is<List<Artist>>(t => t.Count == 0)));
}
[Test]
@@ -196,10 +200,9 @@ namespace NzbDrone.Core.Test.ImportListTests
Subject.Execute(new ImportListSyncCommand());
Mocker.GetMock<IAddAlbumService>()
.Verify(v => v.AddAlbums(It.Is<List<Album>>(t=>t.Count == 1)));
.Verify(v => v.AddAlbums(It.Is<List<Album>>(t => t.Count == 1)));
}
[TestCase(ImportListMonitorType.None, false)]
[TestCase(ImportListMonitorType.SpecificAlbum, true)]
[TestCase(ImportListMonitorType.EntireArtist, true)]
src/NzbDrone.Core.Test/ImportListTests/Spotify/SpotifyFollowedArtistsFixture.cs
+46 -28
View File
@@ -13,7 +13,7 @@ namespace NzbDrone.Core.Test.ImportListTests
public class SpotifyFollowedArtistsFixture : CoreTest<SpotifyFollowedArtists>
{
// placeholder, we don't use real API
private readonly SpotifyWebAPI api = null;
private readonly SpotifyWebAPI _api = null;
[Test]
public void should_not_throw_if_followed_is_null()
@@ -23,7 +23,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<SpotifyWebAPI>()))
.Returns(default(FollowedArtists));
var result = Subject.Fetch(api);
var result = Subject.Fetch(_api);
result.Should().BeEmpty();
}
@@ -31,7 +31,8 @@ namespace NzbDrone.Core.Test.ImportListTests
[Test]
public void should_not_throw_if_followed_artists_is_null()
{
var followed = new FollowedArtists {
var followed = new FollowedArtists
{
Artists = null
};
@@ -40,7 +41,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<SpotifyWebAPI>()))
.Returns(followed);
var result = Subject.Fetch(api);
var result = Subject.Fetch(_api);
result.Should().BeEmpty();
}
@@ -48,8 +49,10 @@ namespace NzbDrone.Core.Test.ImportListTests
[Test]
public void should_not_throw_if_followed_artist_items_is_null()
{
var followed = new FollowedArtists {
Artists = new CursorPaging<FullArtist> {
var followed = new FollowedArtists
{
Artists = new CursorPaging<FullArtist>
{
Items = null
}
};
@@ -59,18 +62,21 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<SpotifyWebAPI>()))
.Returns(followed);
var result = Subject.Fetch(api);
var result = Subject.Fetch(_api);
result.Should().BeEmpty();
Subject.Fetch(api);
Subject.Fetch(_api);
}
[Test]
public void should_not_throw_if_artist_is_null()
{
var followed = new FollowedArtists {
Artists = new CursorPaging<FullArtist> {
Items = new List<FullArtist> {
var followed = new FollowedArtists
{
Artists = new CursorPaging<FullArtist>
{
Items = new List<FullArtist>
{
null
}
}
@@ -81,19 +87,23 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<SpotifyWebAPI>()))
.Returns(followed);
var result = Subject.Fetch(api);
var result = Subject.Fetch(_api);
result.Should().BeEmpty();
Subject.Fetch(api);
Subject.Fetch(_api);
}
[Test]
public void should_parse_followed_artist()
{
var followed = new FollowedArtists {
Artists = new CursorPaging<FullArtist> {
Items = new List<FullArtist> {
new FullArtist {
var followed = new FollowedArtists
{
Artists = new CursorPaging<FullArtist>
{
Items = new List<FullArtist>
{
new FullArtist
{
Name = "artist"
}
}
@@ -105,7 +115,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<SpotifyWebAPI>()))
.Returns(followed);
var result = Subject.Fetch(api);
var result = Subject.Fetch(_api);
result.Should().HaveCount(1);
}
@@ -113,10 +123,14 @@ namespace NzbDrone.Core.Test.ImportListTests
[Test]
public void should_not_throw_if_get_next_page_returns_null()
{
var followed = new FollowedArtists {
Artists = new CursorPaging<FullArtist> {
Items = new List<FullArtist> {
new FullArtist {
var followed = new FollowedArtists
{
Artists = new CursorPaging<FullArtist>
{
Items = new List<FullArtist>
{
new FullArtist
{
Name = "artist"
}
},
@@ -135,7 +149,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<FollowedArtists>()))
.Returns(default(FollowedArtists));
var result = Subject.Fetch(api);
var result = Subject.Fetch(_api);
result.Should().HaveCount(1);
@@ -150,10 +164,14 @@ namespace NzbDrone.Core.Test.ImportListTests
[TestCase("")]
public void should_skip_bad_artist_names(string name)
{
var followed = new FollowedArtists {
Artists = new CursorPaging<FullArtist> {
Items = new List<FullArtist> {
new FullArtist {
var followed = new FollowedArtists
{
Artists = new CursorPaging<FullArtist>
{
Items = new List<FullArtist>
{
new FullArtist
{
Name = name
}
}
@@ -165,7 +183,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<SpotifyWebAPI>()))
.Returns(followed);
var result = Subject.Fetch(api);
var result = Subject.Fetch(_api);
result.Should().BeEmpty();
}
src/NzbDrone.Core.Test/ImportListTests/Spotify/SpotifyMappingFixture.cs
+1 -2
View File
@@ -16,6 +16,7 @@ using NzbDrone.Test.Common;
namespace NzbDrone.Core.Test.ImportListTests
{
[TestFixture]
// the base import list class is abstract so use the followed artists one
public class SpotifyMappingFixture : CoreTest<SpotifyFollowedArtists>
{
@@ -146,7 +147,6 @@ namespace NzbDrone.Core.Test.ImportListTests
Artist = "Adele"
};
Subject.MapAlbumItem(data);
data.Should().NotBeNull();
data.Artist.Should().Be("Adele");
@@ -299,7 +299,6 @@ namespace NzbDrone.Core.Test.ImportListTests
.Setup(x => x.Get<AlbumResource>(It.IsAny<HttpRequest>()))
.Throws(new Exception("Dummy exception"));
var result = Subject.MapSpotifyReleases(data);
result.Should().NotBeNull();
ExceptionVerification.ExpectedErrors(2);
src/NzbDrone.Core.Test/ImportListTests/Spotify/SpotifyPlaylistFixture.cs
+86 -48
View File
@@ -13,7 +13,7 @@ namespace NzbDrone.Core.Test.ImportListTests
public class SpotifyPlaylistFixture : CoreTest<SpotifyPlaylist>
{
// placeholder, we don't use real API
private readonly SpotifyWebAPI api = null;
private readonly SpotifyWebAPI _api = null;
[Test]
public void should_not_throw_if_playlist_tracks_is_null()
@@ -25,7 +25,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<string>()))
.Returns(default(Paging<PlaylistTrack>));
var result = Subject.Fetch(api, "playlistid");
var result = Subject.Fetch(_api, "playlistid");
result.Should().BeEmpty();
}
@@ -33,7 +33,8 @@ namespace NzbDrone.Core.Test.ImportListTests
[Test]
public void should_not_throw_if_playlist_tracks_items_is_null()
{
var playlistTracks = new Paging<PlaylistTrack> {
var playlistTracks = new Paging<PlaylistTrack>
{
Items = null
};
@@ -44,7 +45,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<string>()))
.Returns(playlistTracks);
var result = Subject.Fetch(api, "playlistid");
var result = Subject.Fetch(_api, "playlistid");
result.Should().BeEmpty();
}
@@ -52,8 +53,10 @@ namespace NzbDrone.Core.Test.ImportListTests
[Test]
public void should_not_throw_if_playlist_track_is_null()
{
var playlistTracks = new Paging<PlaylistTrack> {
Items = new List<PlaylistTrack> {
var playlistTracks = new Paging<PlaylistTrack>
{
Items = new List<PlaylistTrack>
{
null
}
};
@@ -65,7 +68,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<string>()))
.Returns(playlistTracks);
var result = Subject.Fetch(api, "playlistid");
var result = Subject.Fetch(_api, "playlistid");
result.Should().BeEmpty();
}
@@ -73,20 +76,29 @@ namespace NzbDrone.Core.Test.ImportListTests
[Test]
public void should_use_album_artist_when_it_exists()
{
var playlistTracks = new Paging<PlaylistTrack> {
Items = new List<PlaylistTrack> {
new PlaylistTrack {
Track = new FullTrack {
Album = new SimpleAlbum {
var playlistTracks = new Paging<PlaylistTrack>
{
Items = new List<PlaylistTrack>
{
new PlaylistTrack
{
Track = new FullTrack
{
Album = new SimpleAlbum
{
Name = "Album",
Artists = new List<SimpleArtist> {
new SimpleArtist {
Artists = new List<SimpleArtist>
{
new SimpleArtist
{
Name = "AlbumArtist"
}
}
},
Artists = new List<SimpleArtist> {
new SimpleArtist {
Artists = new List<SimpleArtist>
{
new SimpleArtist
{
Name = "TrackArtist"
}
}
@@ -102,7 +114,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<string>()))
.Returns(playlistTracks);
var result = Subject.Fetch(api, "playlistid");
var result = Subject.Fetch(_api, "playlistid");
result.Should().HaveCount(1);
result[0].Artist.Should().Be("AlbumArtist");
@@ -111,20 +123,29 @@ namespace NzbDrone.Core.Test.ImportListTests
[Test]
public void should_fall_back_to_track_artist_if_album_artist_missing()
{
var playlistTracks = new Paging<PlaylistTrack> {
Items = new List<PlaylistTrack> {
new PlaylistTrack {
Track = new FullTrack {
Album = new SimpleAlbum {
var playlistTracks = new Paging<PlaylistTrack>
{
Items = new List<PlaylistTrack>
{
new PlaylistTrack
{
Track = new FullTrack
{
Album = new SimpleAlbum
{
Name = "Album",
Artists = new List<SimpleArtist> {
new SimpleArtist {
Artists = new List<SimpleArtist>
{
new SimpleArtist
{
Name = null
}
}
},
Artists = new List<SimpleArtist> {
new SimpleArtist {
Artists = new List<SimpleArtist>
{
new SimpleArtist
{
Name = "TrackArtist"
}
}
@@ -140,32 +161,40 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<string>()))
.Returns(playlistTracks);
var result = Subject.Fetch(api, "playlistid");
var result = Subject.Fetch(_api, "playlistid");
result.Should().HaveCount(1);
result[0].Artist.Should().Be("TrackArtist");
}
[TestCase(null, null, "Album")]
[TestCase("AlbumArtist", null, null)]
[TestCase(null, "TrackArtist", null)]
public void should_skip_bad_artist_or_album_names(string albumArtistName, string trackArtistName, string albumName)
{
var playlistTracks = new Paging<PlaylistTrack> {
Items = new List<PlaylistTrack> {
new PlaylistTrack {
Track = new FullTrack {
Album = new SimpleAlbum {
var playlistTracks = new Paging<PlaylistTrack>
{
Items = new List<PlaylistTrack>
{
new PlaylistTrack
{
Track = new FullTrack
{
Album = new SimpleAlbum
{
Name = albumName,
Artists = new List<SimpleArtist> {
new SimpleArtist {
Artists = new List<SimpleArtist>
{
new SimpleArtist
{
Name = albumArtistName
}
}
},
Artists = new List<SimpleArtist> {
new SimpleArtist {
Artists = new List<SimpleArtist>
{
new SimpleArtist
{
Name = trackArtistName
}
}
@@ -181,7 +210,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<string>()))
.Returns(playlistTracks);
var result = Subject.Fetch(api, "playlistid");
var result = Subject.Fetch(_api, "playlistid");
result.Should().BeEmpty();
}
@@ -189,20 +218,29 @@ namespace NzbDrone.Core.Test.ImportListTests
[Test]
public void should_not_throw_if_get_next_page_returns_null()
{
var playlistTracks = new Paging<PlaylistTrack> {
Items = new List<PlaylistTrack> {
new PlaylistTrack {
Track = new FullTrack {
Album = new SimpleAlbum {
var playlistTracks = new Paging<PlaylistTrack>
{
Items = new List<PlaylistTrack>
{
new PlaylistTrack
{
Track = new FullTrack
{
Album = new SimpleAlbum
{
Name = "Album",
Artists = new List<SimpleArtist> {
new SimpleArtist {
Artists = new List<SimpleArtist>
{
new SimpleArtist
{
Name = null
}
}
},
Artists = new List<SimpleArtist> {
new SimpleArtist {
Artists = new List<SimpleArtist>
{
new SimpleArtist
{
Name = "TrackArtist"
}
}
@@ -225,7 +263,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<Paging<PlaylistTrack>>()))
.Returns(default(Paging<PlaylistTrack>));
var result = Subject.Fetch(api, "playlistid");
var result = Subject.Fetch(_api, "playlistid");
result.Should().HaveCount(1);
src/NzbDrone.Core.Test/ImportListTests/Spotify/SpotifySavedAlbumsFixture.cs
+49 -28
View File
@@ -13,7 +13,7 @@ namespace NzbDrone.Core.Test.ImportListTests
public class SpotifySavedAlbumsFixture : CoreTest<SpotifySavedAlbums>
{
// placeholder, we don't use real API
private readonly SpotifyWebAPI api = null;
private readonly SpotifyWebAPI _api = null;
[Test]
public void should_not_throw_if_saved_albums_is_null()
@@ -23,7 +23,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<SpotifyWebAPI>()))
.Returns(default(Paging<SavedAlbum>));
var result = Subject.Fetch(api);
var result = Subject.Fetch(_api);
result.Should().BeEmpty();
}
@@ -31,7 +31,8 @@ namespace NzbDrone.Core.Test.ImportListTests
[Test]
public void should_not_throw_if_saved_album_items_is_null()
{
var savedAlbums = new Paging<SavedAlbum> {
var savedAlbums = new Paging<SavedAlbum>
{
Items = null
};
@@ -40,7 +41,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<SpotifyWebAPI>()))
.Returns(savedAlbums);
var result = Subject.Fetch(api);
var result = Subject.Fetch(_api);
result.Should().BeEmpty();
}
@@ -48,8 +49,10 @@ namespace NzbDrone.Core.Test.ImportListTests
[Test]
public void should_not_throw_if_saved_album_is_null()
{
var savedAlbums = new Paging<SavedAlbum> {
Items = new List<SavedAlbum> {
var savedAlbums = new Paging<SavedAlbum>
{
Items = new List<SavedAlbum>
{
null
}
};
@@ -59,7 +62,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<SpotifyWebAPI>()))
.Returns(savedAlbums);
var result = Subject.Fetch(api);
var result = Subject.Fetch(_api);
result.Should().BeEmpty();
}
@@ -67,13 +70,19 @@ namespace NzbDrone.Core.Test.ImportListTests
[TestCase("Artist", "Album")]
public void should_parse_saved_album(string artistName, string albumName)
{
var savedAlbums = new Paging<SavedAlbum> {
Items = new List<SavedAlbum> {
new SavedAlbum {
Album = new FullAlbum {
var savedAlbums = new Paging<SavedAlbum>
{
Items = new List<SavedAlbum>
{
new SavedAlbum
{
Album = new FullAlbum
{
Name = albumName,
Artists = new List<SimpleArtist> {
new SimpleArtist {
Artists = new List<SimpleArtist>
{
new SimpleArtist
{
Name = artistName
}
}
@@ -87,7 +96,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<SpotifyWebAPI>()))
.Returns(savedAlbums);
var result = Subject.Fetch(api);
var result = Subject.Fetch(_api);
result.Should().HaveCount(1);
}
@@ -95,13 +104,19 @@ namespace NzbDrone.Core.Test.ImportListTests
[Test]
public void should_not_throw_if_get_next_page_returns_null()
{
var savedAlbums = new Paging<SavedAlbum> {
Items = new List<SavedAlbum> {
new SavedAlbum {
Album = new FullAlbum {
var savedAlbums = new Paging<SavedAlbum>
{
Items = new List<SavedAlbum>
{
new SavedAlbum
{
Album = new FullAlbum
{
Name = "Album",
Artists = new List<SimpleArtist> {
new SimpleArtist {
Artists = new List<SimpleArtist>
{
new SimpleArtist
{
Name = "Artist"
}
}
@@ -122,7 +137,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<Paging<SavedAlbum>>()))
.Returns(default(Paging<SavedAlbum>));
var result = Subject.Fetch(api);
var result = Subject.Fetch(_api);
result.Should().HaveCount(1);
@@ -138,13 +153,19 @@ namespace NzbDrone.Core.Test.ImportListTests
[TestCase(null, null)]
public void should_skip_bad_artist_or_album_names(string artistName, string albumName)
{
var savedAlbums = new Paging<SavedAlbum> {
Items = new List<SavedAlbum> {
new SavedAlbum {
Album = new FullAlbum {
var savedAlbums = new Paging<SavedAlbum>
{
Items = new List<SavedAlbum>
{
new SavedAlbum
{
Album = new FullAlbum
{
Name = albumName,
Artists = new List<SimpleArtist> {
new SimpleArtist {
Artists = new List<SimpleArtist>
{
new SimpleArtist
{
Name = artistName
}
}
@@ -158,7 +179,7 @@ namespace NzbDrone.Core.Test.ImportListTests
It.IsAny<SpotifyWebAPI>()))
.Returns(savedAlbums);
var result = Subject.Fetch(api);
var result = Subject.Fetch(_api);
result.Should().BeEmpty();
}