tedkulp/Readarr
1
0
Fork 0
mirror of https://github.com/Readarr/Readarr.git synced 2026-04-27 22:56:45 -04:00
Code Issues Projects Releases Wiki Activity

Whole album matching and fingerprinting (#592)

Browse Source 
* Cache result of GetAllArtists

* Fixed: Manual import not respecting album import notifications

* Fixed: partial album imports stay in queue, prompting manual import

* Fixed: Allow release if tracks are missing

* Fixed: Be tolerant of missing/extra "The" at start of artist name

* Improve manual import UI

* Omit video tracks from DB entirely

* Revert "faster test packaging in build.sh"

This reverts commit 2723e2a7b8.

-u and -T are not supported on macOS

* Fix tests on linux and macOS

* Actually lint on linux

On linux yarn runs scripts with sh not bash so ** doesn't recursively glob

* Match whole albums

* Option to disable fingerprinting

* Rip out MediaInfo

* Don't split up things that have the same album selected in manual import

* Try to speed up IndentificationService

* More speedups

* Some fixes and increase power of recording id

* Fix NRE when no tags

* Fix NRE when some (but not all) files in a directory have missing tags

* Bump taglib, tidy up tag parsing

* Add a health check

* Remove media info setting

* Tags -> audioTags

* Add some tests where tags are null

* Rename history events

* Add missing method to interface

* Reinstate MediaInfo tags and update info with artist scan

Also adds migration to remove old format media info

* This file no longer exists

* Don't penalise year if missing from tags

* Formatting improvements

* Use correct system newline

* Switch to the netstandard2.0 library to support net 461

* TagLib.File is IDisposable so should be in a using

* Improve filename matching and add tests

* Neater logging of parsed tags

* Fix disk scan tests for new media info update

* Fix quality detection source

* Fix Inexact Artist/Album match

* Add button to clear track mapping

* Fix warning

* Pacify eslint

* Use \ not /

* Fix UI updates

* Fix media covers

Prevent localizing URL propaging back to the metadata object

* Reduce database overhead broadcasting UI updates

* Relax timings a bit to make test pass

* Remove irrelevant tests

* Test framework for identification service

* Fix PreferMissingToBadMatch test case

* Make fingerprinting more robust

* More logging

* Penalize unknown media format and country

* Prefer USA to UK

* Allow Data CD

* Fix exception if fingerprinting fails for all files

* Fix tests

* Fix NRE

* Allow apostrophes and remove accents in filename aggregation

* Address codacy issues

* Cope with old versions of fpcalc and suggest upgrade

* fpcalc health check passes if fingerprinting disabled

* Get the Artist meta with the artist

* Fix the mapper so that lazy loaded lists will be populated on Join

And therefore we can join TrackFiles on Tracks by default and avoid an
extra query

* Rename subtitle -> lyric

* Tidy up MediaInfoFormatter
This commit is contained in:
ta264
2019-02-16 14:49:24 +00:00
committed by Qstick
parent 8bf364945f
commit bb02d73c42
174 changed files with 11577 additions and 3490 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/NzbDrone.Core.Test/ParserTests/ParsingServiceTests/GetLocalTrackFixture.cs
-127
View File
@@ -1,127 +0,0 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using FizzWare.NBuilder;
using FluentAssertions;
using Moq;
using NUnit.Framework;
using NzbDrone.Core.Music;
using NzbDrone.Core.Parser;
using NzbDrone.Core.Parser.Model;
using NzbDrone.Core.Test.Framework;
using NzbDrone.Test.Common;
namespace NzbDrone.Core.Test.ParserTests.ParsingServiceTests
{
[TestFixture]
public class GetLocalTrackFixture : CoreTest<ParsingService>
{
private Artist _fakeArtist;
private Album _fakeAlbum;
private Track _fakeTrack;
private ParsedTrackInfo _parsedTrackInfo;
[SetUp]
public void Setup()
{
_fakeArtist = Builder<Artist>
.CreateNew()
.Build();
_fakeAlbum = Builder<Album>
.CreateNew()
.With(e => e.ArtistId = _fakeArtist.Id)
.With(e => e.AlbumReleases = new List<AlbumRelease>
{
new AlbumRelease
{
ForeignReleaseId = "5ecd552b-e54b-4c37-b62c-9d6234834bad",
Monitored = true
}
})
.Build();
_fakeTrack = Builder<Track>
.CreateNew()
.With(e => e.Artist = _fakeArtist)
.With(e => e.AlbumId = _fakeAlbum.Id)
.With(e => e.Album = null)
.Build();
_parsedTrackInfo = Builder<ParsedTrackInfo>
.CreateNew()
.With(e => e.AlbumTitle = _fakeAlbum.Title)
.With(e => e.Title = _fakeTrack.Title)
.With(e => e.ArtistTitle = _fakeArtist.Name)
.Build();
Mocker.GetMock<IAlbumService>()
.Setup(s => s.FindByTitle(_fakeArtist.Id,_fakeAlbum.Title))
.Returns(_fakeAlbum);
Mocker.GetMock<IAlbumService>()
.Setup(s => s.FindAlbumByRelease(_fakeAlbum.AlbumReleases.Value.First().ForeignReleaseId))
.Returns(_fakeAlbum);
Mocker.GetMock<ITrackService>()
.Setup(s => s.FindTrackByTitle(_fakeArtist.Id, _fakeAlbum.Id, It.IsAny<int>(), It.IsAny<int>(), _fakeTrack.Title))
.Returns(_fakeTrack);
}
private void HasAlbumTitleNoReleaseId()
{
_parsedTrackInfo.AlbumTitle = _fakeAlbum.Title;
_parsedTrackInfo.ReleaseMBId = "";
}
private void HasReleaseMbIdNoTitle()
{
_parsedTrackInfo.AlbumTitle = "";
_parsedTrackInfo.ReleaseMBId = _fakeAlbum.AlbumReleases.Value.First().ForeignReleaseId;
}
private void HasNoReleaseIdOrTitle()
{
_parsedTrackInfo.AlbumTitle = "";
_parsedTrackInfo.ReleaseMBId = "";
}
[Test]
public void should_find_album_with_title_no_MBID()
{
HasAlbumTitleNoReleaseId();
var localTrack = Subject.GetLocalTrack("somfile.mp3", _fakeArtist, _parsedTrackInfo);
localTrack.Artist.Id.Should().Be(_fakeArtist.Id);
localTrack.Album.Id.Should().Be(_fakeAlbum.Id);
localTrack.Tracks.First().Id.Should().Be(_fakeTrack.Id);
}
[Test]
public void should_find_album_with_release_MBID_no_title()
{
HasReleaseMbIdNoTitle();
var localTrack = Subject.GetLocalTrack("somfile.mp3", _fakeArtist, _parsedTrackInfo);
localTrack.Artist.Id.Should().Be(_fakeArtist.Id);
localTrack.Album.Id.Should().Be(_fakeAlbum.Id);
localTrack.Tracks.First().Id.Should().Be(_fakeTrack.Id);
}
[Test]
public void should_not_find_album_with_no_release_MBID_no_title()
{
HasNoReleaseIdOrTitle();
var localTrack = Subject.GetLocalTrack("somfile.mp3", _fakeArtist, _parsedTrackInfo);
ExceptionVerification.ExpectedWarns(1);
localTrack.Should().BeNull();
}
}
}