New: Add tag support to indexers

(cherry picked from commit c3d54b312ef18b837d54605ea78f1a263fd6900b)
2026-04-26 22:46:37 -04:00 · 2021-03-22 00:00:06 +00:00
parent 10e230cc06
commit b97d63cb5b
21 changed files with 454 additions and 25 deletions
@@ -0,0 +1,110 @@
+using System.Collections.Generic;
+using FizzWare.NBuilder;
+using FluentAssertions;
+using Moq;
+using NUnit.Framework;
+using NzbDrone.Core.Books;
+using NzbDrone.Core.DecisionEngine.Specifications.RssSync;
+using NzbDrone.Core.Indexers;
+using NzbDrone.Core.IndexerSearch.Definitions;
+using NzbDrone.Core.Parser.Model;
+using NzbDrone.Core.Test.Framework;
+
+namespace NzbDrone.Core.Test.DecisionEngineTests.RssSync
+{
+    [TestFixture]
+    public class IndexerTagSpecificationFixture : CoreTest<IndexerTagSpecification>
+    {
+        private IndexerTagSpecification _specification;
+
+        private RemoteBook _parseResultMulti;
+        private IndexerDefinition _fakeIndexerDefinition;
+        private Author _fakeAuthor;
+        private Book _firstBook;
+        private Book _secondBook;
+        private ReleaseInfo _fakeRelease;
+
+        [SetUp]
+        public void Setup()
+        {
+            _fakeIndexerDefinition = new IndexerDefinition
+            {
+                Tags = new HashSet<int>()
+            };
+
+            Mocker
+                .GetMock<IIndexerRepository>()
+                .Setup(m => m.Get(It.IsAny<int>()))
+                .Returns(_fakeIndexerDefinition);
+
+            _specification = Mocker.Resolve<IndexerTagSpecification>();
+
+            _fakeAuthor = Builder<Author>.CreateNew()
+                .With(c => c.Monitored = true)
+                .With(c => c.Tags = new HashSet<int>())
+                .Build();
+
+            _fakeRelease = new ReleaseInfo
+            {
+                IndexerId = 1
+            };
+
+            _firstBook = new Book { Monitored = true };
+            _secondBook = new Book { Monitored = true };
+
+            var doubleBookList = new List<Book> { _firstBook, _secondBook };
+
+            _parseResultMulti = new RemoteBook
+            {
+                Author = _fakeAuthor,
+                Books = doubleBookList,
+                Release = _fakeRelease
+            };
+        }
+
+        [Test]
+        public void indexer_and_author_without_tags_should_return_true()
+        {
+            _fakeIndexerDefinition.Tags = new HashSet<int>();
+            _fakeAuthor.Tags = new HashSet<int>();
+
+            _specification.IsSatisfiedBy(_parseResultMulti, new BookSearchCriteria { MonitoredBooksOnly = true }).Accepted.Should().BeTrue();
+        }
+
+        [Test]
+        public void indexer_with_tags_author_without_tags_should_return_false()
+        {
+            _fakeIndexerDefinition.Tags = new HashSet<int> { 123 };
+            _fakeAuthor.Tags = new HashSet<int>();
+
+            _specification.IsSatisfiedBy(_parseResultMulti, new BookSearchCriteria { MonitoredBooksOnly = true }).Accepted.Should().BeFalse();
+        }
+
+        [Test]
+        public void indexer_without_tags_author_with_tags_should_return_true()
+        {
+            _fakeIndexerDefinition.Tags = new HashSet<int>();
+            _fakeAuthor.Tags = new HashSet<int> { 123 };
+
+            _specification.IsSatisfiedBy(_parseResultMulti, new BookSearchCriteria { MonitoredBooksOnly = true }).Accepted.Should().BeTrue();
+        }
+
+        [Test]
+        public void indexer_with_tags_author_with_matching_tags_should_return_true()
+        {
+            _fakeIndexerDefinition.Tags = new HashSet<int> { 123, 456 };
+            _fakeAuthor.Tags = new HashSet<int> { 123, 789 };
+
+            _specification.IsSatisfiedBy(_parseResultMulti, new BookSearchCriteria { MonitoredBooksOnly = true }).Accepted.Should().BeTrue();
+        }
+
+        [Test]
+        public void indexer_with_tags_author_with_different_tags_should_return_false()
+        {
+            _fakeIndexerDefinition.Tags = new HashSet<int> { 456 };
+            _fakeAuthor.Tags = new HashSet<int> { 123, 789 };
+
+            _specification.IsSatisfiedBy(_parseResultMulti, new BookSearchCriteria { MonitoredBooksOnly = true }).Accepted.Should().BeFalse();
+        }
+    }
+}
@@ -0,0 +1,166 @@
+using System.Collections.Generic;
+using System.Linq;
+using FizzWare.NBuilder;
+using FluentAssertions;
+using Moq;
+using NUnit.Framework;
+using NzbDrone.Core.Books;
+using NzbDrone.Core.DecisionEngine;
+using NzbDrone.Core.Indexers;
+using NzbDrone.Core.IndexerSearch;
+using NzbDrone.Core.IndexerSearch.Definitions;
+using NzbDrone.Core.Test.Framework;
+
+namespace NzbDrone.Core.Test.IndexerSearchTests
+{
+        public class ReleaseSearchServiceFixture : CoreTest<ReleaseSearchService>
+    {
+        private Mock<IIndexer> _mockIndexer;
+        private Author _author;
+        private Book _firstBook;
+
+        [SetUp]
+        public void SetUp()
+        {
+            _mockIndexer = Mocker.GetMock<IIndexer>();
+            _mockIndexer.SetupGet(s => s.Definition).Returns(new IndexerDefinition { Id = 1 });
+            _mockIndexer.SetupGet(s => s.SupportsSearch).Returns(true);
+
+            Mocker.GetMock<IIndexerFactory>()
+                  .Setup(s => s.AutomaticSearchEnabled(true))
+                  .Returns(new List<IIndexer> { _mockIndexer.Object });
+
+            Mocker.GetMock<IMakeDownloadDecision>()
+                .Setup(s => s.GetSearchDecision(It.IsAny<List<Parser.Model.ReleaseInfo>>(), It.IsAny<SearchCriteriaBase>()))
+                .Returns(new List<DownloadDecision>());
+
+            _author = Builder<Author>.CreateNew()
+                .With(v => v.Monitored = true)
+                .Build();
+
+            _firstBook = Builder<Book>.CreateNew()
+                .With(e => e.Author = _author)
+                .Build();
+
+            var edition = Builder<Edition>.CreateNew()
+                .With(e => e.Book = _firstBook)
+                .With(e => e.Monitored = true)
+                .Build();
+
+            _firstBook.Editions = new List<Edition> { edition };
+
+            Mocker.GetMock<IAuthorService>()
+                .Setup(v => v.GetAuthor(_author.Id))
+                .Returns(_author);
+        }
+
+        private List<SearchCriteriaBase> WatchForSearchCriteria()
+        {
+            var result = new List<SearchCriteriaBase>();
+
+            _mockIndexer.Setup(v => v.Fetch(It.IsAny<BookSearchCriteria>()))
+                .Callback<BookSearchCriteria>(s => result.Add(s))
+                .Returns(new List<Parser.Model.ReleaseInfo>());
+
+            return result;
+        }
+
+        [Test]
+        public void Tags_IndexerTags_AuthorNoTags_IndexerNotIncluded()
+        {
+            _mockIndexer.SetupGet(s => s.Definition).Returns(new IndexerDefinition
+            {
+                Id = 1,
+                Tags = new HashSet<int> { 3 }
+            });
+
+            var allCriteria = WatchForSearchCriteria();
+
+            Subject.BookSearch(_firstBook, false, true, false);
+
+            var criteria = allCriteria.OfType<BookSearchCriteria>().ToList();
+
+            criteria.Count.Should().Be(0);
+        }
+
+        [Test]
+        public void Tags_IndexerNoTags_AuthorTags_IndexerIncluded()
+        {
+            _mockIndexer.SetupGet(s => s.Definition).Returns(new IndexerDefinition
+            {
+                Id = 1
+            });
+
+            _author = Builder<Author>.CreateNew()
+                .With(v => v.Monitored = true)
+                .With(v => v.Tags = new HashSet<int> { 3 })
+                .Build();
+
+            Mocker.GetMock<IAuthorService>()
+                .Setup(v => v.GetAuthor(_author.Id))
+                .Returns(_author);
+
+            var allCriteria = WatchForSearchCriteria();
+
+            Subject.BookSearch(_firstBook, false, true, false);
+
+            var criteria = allCriteria.OfType<BookSearchCriteria>().ToList();
+
+            criteria.Count.Should().Be(1);
+        }
+
+        [Test]
+        public void Tags_IndexerAndAuthorTagsMatch_IndexerIncluded()
+        {
+            _mockIndexer.SetupGet(s => s.Definition).Returns(new IndexerDefinition
+            {
+                Id = 1,
+                Tags = new HashSet<int> { 1, 2, 3 }
+            });
+
+            _author = Builder<Author>.CreateNew()
+                .With(v => v.Monitored = true)
+                .With(v => v.Tags = new HashSet<int> { 3, 4, 5 })
+                .Build();
+
+            Mocker.GetMock<IAuthorService>()
+                .Setup(v => v.GetAuthor(_author.Id))
+                .Returns(_author);
+
+            var allCriteria = WatchForSearchCriteria();
+
+            Subject.BookSearch(_firstBook, false, true, false);
+
+            var criteria = allCriteria.OfType<BookSearchCriteria>().ToList();
+
+            criteria.Count.Should().Be(1);
+        }
+
+        [Test]
+        public void Tags_IndexerAndAuthorTagsMismatch_IndexerNotIncluded()
+        {
+            _mockIndexer.SetupGet(s => s.Definition).Returns(new IndexerDefinition
+            {
+                Id = 1,
+                Tags = new HashSet<int> { 1, 2, 3 }
+            });
+
+            _author = Builder<Author>.CreateNew()
+                .With(v => v.Monitored = true)
+                .With(v => v.Tags = new HashSet<int> { 4, 5, 6 })
+                .Build();
+
+            Mocker.GetMock<IAuthorService>()
+                .Setup(v => v.GetAuthor(_author.Id))
+                .Returns(_author);
+
+            var allCriteria = WatchForSearchCriteria();
+
+            Subject.BookSearch(_firstBook, false, true, false);
+
+            var criteria = allCriteria.OfType<BookSearchCriteria>().ToList();
+
+            criteria.Count.Should().Be(0);
+        }
+    }
+}