Fixed: Detect Kodi nfo vs. Scene nfo. Other extras fixes

Fixes #240 Co-Authored-By: taloth <taloth@users.noreply.github.com>
2026-04-22 22:14:44 -04:00 · 2018-03-19 21:38:02 -04:00
parent 9d056006cc
commit b03b3d8243
15 changed files with 249 additions and 153 deletions
@@ -0,0 +1,77 @@
+using System.IO;
+using FizzWare.NBuilder;
+using FluentAssertions;
+using NUnit.Framework;
+using NzbDrone.Core.Extras.Metadata;
+using NzbDrone.Core.Extras.Metadata.Consumers.Roksbox;
+using NzbDrone.Core.Test.Framework;
+using NzbDrone.Core.Music;
+using NzbDrone.Test.Common;
+
+namespace NzbDrone.Core.Test.Extras.Metadata.Consumers.Roksbox
+{
+    [TestFixture]
+    public class FindMetadataFileFixture : CoreTest<RoksboxMetadata>
+    {
+        private Artist _artist;
+
+        [SetUp]
+        public void Setup()
+        {
+            _artist = Builder<Artist>.CreateNew()
+                                     .With(s => s.Path = @"C:\Test\Music\The.Artist".AsOsAgnostic())
+                                     .Build();
+        }
+
+        [Test]
+        public void should_return_null_if_filename_is_not_handled()
+        {
+            var path = Path.Combine(_artist.Path, "file.jpg");
+
+            Subject.FindMetadataFile(_artist, path).Should().BeNull();
+        }
+
+        [TestCase("Specials")]
+        [TestCase("specials")]
+        [TestCase("Season 1")]
+        public void should_return_album_image(string folder)
+        {
+            var path = Path.Combine(_artist.Path, folder, folder + ".jpg");
+
+            Subject.FindMetadataFile(_artist, path).Type.Should().Be(MetadataType.AlbumImage);
+        }
+
+        [TestCase(".xml", MetadataType.TrackMetadata)]
+        public void should_return_metadata_for_track_if_valid_file_for_track(string extension, MetadataType type)
+        {
+            var path = Path.Combine(_artist.Path, "the.artist.s01e01.track" + extension);
+
+            Subject.FindMetadataFile(_artist, path).Type.Should().Be(type);
+        }
+
+        [TestCase(".xml")]
+        [TestCase(".jpg")]
+        public void should_return_null_if_not_valid_file_for_track(string extension)
+        {
+            var path = Path.Combine(_artist.Path, "the.artist.track" + extension);
+
+            Subject.FindMetadataFile(_artist, path).Should().BeNull();
+        }
+
+        [Test]
+        public void should_not_return_metadata_if_image_file_is_a_thumb()
+        {
+            var path = Path.Combine(_artist.Path, "the.artist.s01e01.track-thumb.jpg");
+
+            Subject.FindMetadataFile(_artist, path).Should().BeNull();
+        }
+
+        [Test]
+        public void should_return_artist_image_for_folder_jpg_in_artist_folder()
+        {
+            var path = Path.Combine(_artist.Path, new DirectoryInfo(_artist.Path).Name + ".jpg");
+
+            Subject.FindMetadataFile(_artist, path).Type.Should().Be(MetadataType.ArtistImage);
+        }
+    }
+}
@@ -0,0 +1,69 @@
+using System.IO;
+using FizzWare.NBuilder;
+using FluentAssertions;
+using NUnit.Framework;
+using NzbDrone.Core.Extras.Metadata;
+using NzbDrone.Core.Extras.Metadata.Consumers.Wdtv;
+using NzbDrone.Core.Test.Framework;
+using NzbDrone.Core.Music;
+using NzbDrone.Test.Common;
+
+namespace NzbDrone.Core.Test.Extras.Metadata.Consumers.Wdtv
+{
+    [TestFixture]
+    public class FindMetadataFileFixture : CoreTest<WdtvMetadata>
+    {
+        private Artist _artist;
+
+        [SetUp]
+        public void Setup()
+        {
+            _artist = Builder<Artist>.CreateNew()
+                                     .With(s => s.Path = @"C:\Test\Music\The.Artist".AsOsAgnostic())
+                                     .Build();
+        }
+
+        [Test]
+        public void should_return_null_if_filename_is_not_handled()
+        {
+            var path = Path.Combine(_artist.Path, "file.jpg");
+
+            Subject.FindMetadataFile(_artist, path).Should().BeNull();
+        }
+
+        [TestCase("Specials")]
+        [TestCase("specials")]
+        [TestCase("Season 1")]
+        public void should_return_album_image(string folder)
+        {
+            var path = Path.Combine(_artist.Path, folder, "folder.jpg");
+
+            Subject.FindMetadataFile(_artist, path).Type.Should().Be(MetadataType.AlbumImage);
+        }
+
+        [TestCase(".xml", MetadataType.TrackMetadata)]
+        public void should_return_metadata_for_track_if_valid_file_for_track(string extension, MetadataType type)
+        {
+            var path = Path.Combine(_artist.Path, "the.artist.s01e01.track" + extension);
+
+            Subject.FindMetadataFile(_artist, path).Type.Should().Be(type);
+        }
+
+        [TestCase(".xml")]
+        [TestCase(".metathumb")]
+        public void should_return_null_if_not_valid_file_for_track(string extension)
+        {
+            var path = Path.Combine(_artist.Path, "the.artist.track" + extension);
+
+            Subject.FindMetadataFile(_artist, path).Should().BeNull();
+        }
+
+        [Test]
+        public void should_return_artist_image_for_folder_jpg_in_artist_folder()
+        {
+            var path = Path.Combine(_artist.Path, "folder.jpg");
+
+            Subject.FindMetadataFile(_artist, path).Type.Should().Be(MetadataType.ArtistImage);
+        }
+    }
+}
@@ -0,0 +1,65 @@
+using System.IO;
+using FizzWare.NBuilder;
+using FluentAssertions;
+using Moq;
+using NUnit.Framework;
+using NzbDrone.Core.Extras.Metadata;
+using NzbDrone.Core.Extras.Metadata.Consumers.Xbmc;
+using NzbDrone.Core.Test.Framework;
+using NzbDrone.Core.Music;
+using NzbDrone.Test.Common;
+
+namespace NzbDrone.Core.Test.Extras.Metadata.Consumers.Xbmc
+{
+    [TestFixture]
+    public class FindMetadataFileFixture : CoreTest<XbmcMetadata>
+    {
+        private Artist _artist;
+
+        [SetUp]
+        public void Setup()
+        {
+            _artist = Builder<Artist>.CreateNew()
+                                     .With(s => s.Path = @"C:\Test\Music\The.Artist".AsOsAgnostic())
+                                     .Build();
+        }
+
+        [Test]
+        public void should_return_null_if_filename_is_not_handled()
+        {
+            var path = Path.Combine(_artist.Path, "file.jpg");
+
+            Subject.FindMetadataFile(_artist, path).Should().BeNull();
+        }
+
+        [Test]
+        public void should_return_metadata_for_xbmc_nfo()
+        {
+            var path = Path.Combine(_artist.Path, "album.nfo");
+
+            Mocker.GetMock<IDetectXbmcNfo>()
+                  .Setup(v => v.IsXbmcNfoFile(path))
+                  .Returns(true);
+
+            Subject.FindMetadataFile(_artist, path).Type.Should().Be(MetadataType.AlbumMetadata);
+
+            Mocker.GetMock<IDetectXbmcNfo>()
+                  .Verify(v => v.IsXbmcNfoFile(It.IsAny<string>()), Times.Once());
+        }
+
+        [Test]
+        public void should_return_null_for_scene_nfo()
+        {
+            var path = Path.Combine(_artist.Path, "album.nfo");
+
+            Mocker.GetMock<IDetectXbmcNfo>()
+                  .Setup(v => v.IsXbmcNfoFile(path))
+                  .Returns(false);
+
+            Subject.FindMetadataFile(_artist, path).Should().BeNull();
+
+            Mocker.GetMock<IDetectXbmcNfo>()
+                  .Verify(v => v.IsXbmcNfoFile(It.IsAny<string>()), Times.Once());
+        }
+    }
+}