New: Better platform detection specifically for Non-Windows Systems

2026-04-24 22:35:39 -04:00 · 2017-01-03 18:36:47 -08:00
parent 598b5322b7
commit ad7d571b24
76 changed files with 1125 additions and 473 deletions
@@ -0,0 +1,77 @@
+using System;
+using System.IO;
+using FluentAssertions;
+using Moq;
+using NUnit.Framework;
+using NzbDrone.Common.Disk;
+using NzbDrone.Mono.EnvironmentInfo.VersionAdapters;
+using NzbDrone.Test.Common;
+
+namespace NzbDrone.Mono.Test.EnvironmentInfo.VersionAdapters
+{
+    [TestFixture]
+    public class MacOsVersionAdapterFixture : TestBase<MacOsVersionAdapter>
+    {
+        [TestCase("10.8.0")]
+        [TestCase("10.8")]
+        [TestCase("10.8.1")]
+        [TestCase("10.11.20")]
+        public void should_get_version_info(string versionString)
+        {
+            var fileContent = File.ReadAllText(GetTestPath("Files/macOS/SystemVersion.plist")).Replace("10.0.0", versionString);
+
+            const string plistPath = "/System/Library/CoreServices/SystemVersion.plist";
+
+            Mocker.GetMock<IDiskProvider>()
+                .Setup(c => c.FolderExists("/System/Library/CoreServices/")).Returns(true);
+
+            Mocker.GetMock<IDiskProvider>()
+                .Setup(c => c.GetFiles("/System/Library/CoreServices/", SearchOption.TopDirectoryOnly))
+                .Returns(new[] { plistPath });
+
+            Mocker.GetMock<IDiskProvider>()
+                .Setup(c => c.ReadAllText(plistPath))
+                .Returns(fileContent);
+
+            var versionName = Subject.Read();
+            versionName.Version.Should().Be(versionString);
+            versionName.Name.Should().Be("macOS");
+            versionName.FullName.Should().Be("macOS " + versionString);
+        }
+
+
+        [TestCase]
+        public void should_detect_server()
+        {
+            var fileContent = File.ReadAllText(GetTestPath("Files/macOS/SystemVersion.plist"));
+
+            const string plistPath = "/System/Library/CoreServices/ServerVersion.plist";
+
+            Mocker.GetMock<IDiskProvider>()
+               .Setup(c => c.FolderExists("/System/Library/CoreServices/")).Returns(true);
+
+            Mocker.GetMock<IDiskProvider>()
+                .Setup(c => c.GetFiles("/System/Library/CoreServices/", SearchOption.TopDirectoryOnly))
+                .Returns(new[] { plistPath });
+
+            Mocker.GetMock<IDiskProvider>()
+                .Setup(c => c.ReadAllText(plistPath))
+                .Returns(fileContent);
+
+            var versionName = Subject.Read();
+            versionName.Name.Should().Be("macOS Server");
+        }
+
+        [TestCase]
+        public void should_return_null_if_folder_doesnt_exist()
+        {
+            Mocker.GetMock<IDiskProvider>()
+               .Setup(c => c.FolderExists("/System/Library/CoreServices/")).Returns(false);
+
+            Subject.Read().Should().BeNull();
+
+            Mocker.GetMock<IDiskProvider>()
+                .Verify(c => c.GetFiles(It.IsAny<string>(), SearchOption.TopDirectoryOnly), Times.Never());
+        }
+    }
+}
@@ -0,0 +1,82 @@
+using System.IO;
+using FluentAssertions;
+using Moq;
+using NUnit.Framework;
+using NzbDrone.Common.Disk;
+using NzbDrone.Mono.Disk;
+using NzbDrone.Mono.EnvironmentInfo.VersionAdapters;
+using NzbDrone.Test.Common;
+using NzbDrone.Test.Common.Categories;
+
+namespace NzbDrone.Mono.Test.EnvironmentInfo.VersionAdapters
+{
+    [TestFixture]
+    public class ReleaseFileVersionAdapterFixture : TestBase<ReleaseFileVersionAdapter>
+    {
+        [Test]
+        [IntegrationTest]
+        [Platform("Mono")]
+        public void should_get_version_info_from_actual_linux()
+        {
+            Mocker.SetConstant<IDiskProvider>(Mocker.Resolve<DiskProvider>());
+            var info = Subject.Read();
+            info.FullName.Should().NotBeNullOrWhiteSpace();
+            info.Name.Should().NotBeNullOrWhiteSpace();
+            info.Version.Should().NotBeNullOrWhiteSpace();
+        }
+
+        [Test]
+        public void should_return_null_if_etc_doestn_exist()
+        {
+            Mocker.GetMock<IDiskProvider>().Setup(c => c.FolderExists("/etc/")).Returns(false);
+            Subject.Read().Should().BeNull();
+
+            Mocker.GetMock<IDiskProvider>()
+              .Verify(c => c.GetFiles(It.IsAny<string>(), SearchOption.TopDirectoryOnly), Times.Never());
+
+            Subject.Read().Should().BeNull();
+        }
+
+
+        [Test]
+        public void should_return_null_if_release_file_doestn_exist()
+        {
+            Mocker.GetMock<IDiskProvider>().Setup(c => c.FolderExists("/etc/")).Returns(true);
+            Subject.Read().Should().BeNull();
+
+            Mocker.GetMock<IDiskProvider>()
+              .Setup(c => c.GetFiles(It.IsAny<string>(), SearchOption.TopDirectoryOnly)).Returns(new string[0]);
+
+            Subject.Read().Should().BeNull();
+        }
+
+        [Test]
+        public void should_detect_version()
+        {
+            Mocker.GetMock<IDiskProvider>().Setup(c => c.FolderExists("/etc/")).Returns(true);
+            Subject.Read().Should().BeNull();
+
+            Mocker.GetMock<IDiskProvider>()
+              .Setup(c => c.GetFiles(It.IsAny<string>(), SearchOption.TopDirectoryOnly)).Returns(new[]
+                {
+                    "/etc/lsb-release",
+                    "/etc/os-release"
+                });
+
+            Mocker.GetMock<IDiskProvider>()
+                .Setup(c => c.ReadAllText("/etc/lsb-release"))
+                .Returns(File.ReadAllText(GetTestPath("Files/linux/lsb-release")));
+
+            Mocker.GetMock<IDiskProvider>()
+                .Setup(c => c.ReadAllText("/etc/os-release"))
+                .Returns(File.ReadAllText(GetTestPath("Files/linux/os-release")));
+
+            var version = Subject.Read();
+            version.Should().NotBeNull();
+            version.Name.Should().Be("ubuntu");
+            version.Version.Should().Be("14.04");
+            version.FullName.Should().Be("Ubuntu 14.04.5 LTS");
+
+        }
+    }
+}