Fixed: Significantly improved api performance.

2026-04-25 22:36:59 -04:00 · 2016-03-25 01:56:29 +01:00
parent ff6737314f
commit a2536deef0
118 changed files with 2195 additions and 1019 deletions
@@ -58,7 +58,7 @@ namespace NzbDrone.Core.ThingiProvider
                    };
                }

-                definition = GetProviderCharacteristics(provider, definition);
+                SetProviderCharacteristics(provider, definition);

                yield return definition;
            }
@@ -117,7 +117,8 @@ namespace NzbDrone.Core.ThingiProvider
        {
            var type = GetImplementation(definition);
            var instance = (TProvider)_container.Resolve(type);
-            instance.Definition = GetProviderCharacteristics(instance, definition);
+            instance.Definition = definition;
+            SetProviderCharacteristics(instance, definition);
            return instance;
        }

@@ -144,12 +145,15 @@ namespace NzbDrone.Core.ThingiProvider
            return All().Where(c => c.Settings.Validate().IsValid).ToList();
        }

-        public virtual TProviderDefinition GetProviderCharacteristics(TProvider provider, TProviderDefinition definition)
+        public void SetProviderCharacteristics(TProviderDefinition definition)
+        {
+            GetInstance(definition);
+        }
+
+        public virtual void SetProviderCharacteristics(TProvider provider, TProviderDefinition definition)
        {
            definition.ImplementationName = provider.Name;
            definition.Message = provider.Message;
-
-            return definition;
        }

        //TODO: Remove providers even if the ConfigContract can't be deserialized (this will fail to remove providers if the settings can't be deserialized).