tedkulp/Readarr
1
0
Fork 0
mirror of https://github.com/Readarr/Readarr.git synced 2026-04-20 21:54:25 -04:00
Code Issues Projects Releases Wiki Activity

Fixed: Skyhook Tests, Validate GUID before sending to metadata api

Browse Source
This commit is contained in:
Qstick
2017-12-28 22:47:19 -05:00
parent bc8bd9995a
commit 9cd60bc986
3 changed files with 74 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/NzbDrone.Core/MetadataSource/SkyHook/SkyHookProxy.cs
+8 -2
View File
@@ -70,6 +70,10 @@ namespace NzbDrone.Core.MetadataSource.SkyHook
{
throw new ArtistNotFoundException(foreignArtistId);
}
else if (httpResponse.StatusCode == HttpStatusCode.BadRequest)
{
throw new BadRequestException(foreignArtistId);
}
else
{
throw new HttpException(httpRequest, httpResponse);
@@ -93,7 +97,9 @@ namespace NzbDrone.Core.MetadataSource.SkyHook
{
var slug = lowerTitle.Split(':')[1].Trim();
if (slug.IsNullOrWhiteSpace() || slug.Any(char.IsWhiteSpace))
bool isValid = Guid.TryParse(slug, out var searchGuid);
if (slug.IsNullOrWhiteSpace() || slug.Any(char.IsWhiteSpace) || isValid == false)
{
return new List<Artist>();
}
@@ -101,7 +107,7 @@ namespace NzbDrone.Core.MetadataSource.SkyHook
try
{
var metadataProfile = _metadataProfileService.All().First().Id; //Change this to Use last Used profile?
return new List<Artist> { GetArtistInfo(slug, metadataProfile).Item1 };
return new List<Artist> { GetArtistInfo(searchGuid.ToString(), metadataProfile).Item1 };
}
catch (ArtistNotFoundException)
{