Revert "Move all data fetching to BookInfo"

This reverts commit f6ff53ca31.
2026-04-20 21:54:25 -04:00 · 2021-12-26 19:01:35 +00:00
parent 399a370e7a
commit 9a2260a00f
28 changed files with 928 additions and 578 deletions
@@ -1,126 +0,0 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using FluentAssertions;
-using Moq;
-using NUnit.Framework;
-using NzbDrone.Core.Books;
-using NzbDrone.Core.Exceptions;
-using NzbDrone.Core.MetadataSource.BookInfo;
-using NzbDrone.Core.Profiles.Metadata;
-using NzbDrone.Core.Test.Framework;
-
-namespace NzbDrone.Core.Test.MetadataSource.Goodreads
-{
-    [TestFixture]
-    public class BookInfoProxyFixture : CoreTest<BookInfoProxy>
-    {
-        private MetadataProfile _metadataProfile;
-
-        [SetUp]
-        public void Setup()
-        {
-            UseRealHttp();
-
-            _metadataProfile = new MetadataProfile();
-
-            Mocker.GetMock<IMetadataProfileService>()
-                .Setup(s => s.Get(It.IsAny<int>()))
-                .Returns(_metadataProfile);
-
-            Mocker.GetMock<IMetadataProfileService>()
-                .Setup(s => s.Exists(It.IsAny<int>()))
-                .Returns(true);
-        }
-
-        [TestCase("1654", "Terry Pratchett")]
-        [TestCase("575", "Robert Harris")]
-        public void should_be_able_to_get_author_detail(string mbId, string name)
-        {
-            var details = Subject.GetAuthorInfo(mbId);
-
-            ValidateAuthor(details);
-
-            details.Name.Should().Be(name);
-        }
-
-        [TestCase("1128601", "Guards! Guards!")]
-        [TestCase("3293141", "Ιλιάς")]
-        public void should_be_able_to_get_book_detail(string mbId, string name)
-        {
-            var details = Subject.GetBookInfo(mbId);
-
-            ValidateBooks(new List<Book> { details.Item2 });
-
-            details.Item2.Title.Should().Be(name);
-        }
-
-        [TestCase("14190696", "The Book of Dust", "1")]
-        [TestCase("48427681", "October Daye Chronological Order", "7.1")]
-        public void should_parse_series_from_title(string id, string series, string position)
-        {
-            var result = Subject.GetBookInfo(id);
-
-            var link = result.Item2.SeriesLinks.Value.OrderBy(x => x.SeriesPosition).First();
-            link.Series.Value.Title.Should().Be(series);
-            link.Position.Should().Be(position);
-        }
-
-        [Test]
-        public void getting_details_of_invalid_author()
-        {
-            Assert.Throws<AuthorNotFoundException>(() => Subject.GetAuthorInfo("1"));
-        }
-
-        [Test]
-        public void getting_details_of_invalid_book()
-        {
-            Assert.Throws<BookNotFoundException>(() => Subject.GetBookInfo("99999999"));
-        }
-
-        private void ValidateAuthor(Author author)
-        {
-            author.Should().NotBeNull();
-            author.Name.Should().NotBeNullOrWhiteSpace();
-            author.CleanName.Should().Be(Parser.Parser.CleanAuthorName(author.Name));
-            author.Metadata.Value.TitleSlug.Should().NotBeNullOrWhiteSpace();
-            author.Metadata.Value.Overview.Should().NotBeNullOrWhiteSpace();
-            author.Metadata.Value.Images.Should().NotBeEmpty();
-            author.ForeignAuthorId.Should().NotBeNullOrWhiteSpace();
-        }
-
-        private void ValidateBooks(List<Book> books, bool idOnly = false)
-        {
-            books.Should().NotBeEmpty();
-
-            foreach (var book in books)
-            {
-                book.ForeignBookId.Should().NotBeNullOrWhiteSpace();
-                if (!idOnly)
-                {
-                    ValidateBook(book);
-                }
-            }
-
-            //if atleast one book has title it means parse it working.
-            if (!idOnly)
-            {
-                books.Should().Contain(c => !string.IsNullOrWhiteSpace(c.Title));
-            }
-        }
-
-        private void ValidateBook(Book book)
-        {
-            book.Should().NotBeNull();
-
-            book.Title.Should().NotBeNullOrWhiteSpace();
-
-            book.Should().NotBeNull();
-
-            if (book.ReleaseDate.HasValue)
-            {
-                book.ReleaseDate.Value.Kind.Should().Be(DateTimeKind.Utc);
-            }
-        }
-    }
-}