Improve decision processing and deleting of pending releases

2026-04-20 21:54:25 -04:00 · 2014-07-26 17:39:28 -07:00
parent 5450170718
commit 9410e01c92
7 changed files with 389 additions and 40 deletions
@@ -0,0 +1,155 @@
+using System;
+using System.Collections.Generic;
+using FizzWare.NBuilder;
+using Marr.Data;
+using Moq;
+using NUnit.Framework;
+using NzbDrone.Core.DecisionEngine;
+using NzbDrone.Core.Download.Pending;
+using NzbDrone.Core.Parser;
+using NzbDrone.Core.Parser.Model;
+using NzbDrone.Core.Profiles;
+using NzbDrone.Core.Qualities;
+using NzbDrone.Core.Test.Framework;
+using NzbDrone.Core.Tv;
+using NzbDrone.Test.Common;
+
+namespace NzbDrone.Core.Test.Download.Pending.PendingReleaseServiceTests
+{
+    [TestFixture]
+    public class RemoveRejectedFixture : CoreTest<PendingReleaseService>
+    {
+        private DownloadDecision _temporarilyRejected;
+        private Series _series;
+        private Episode _episode;
+        private Profile _profile;
+        private ReleaseInfo _release;
+        private ParsedEpisodeInfo _parsedEpisodeInfo;
+        private RemoteEpisode _remoteEpisode;
+
+        [SetUp]
+        public void Setup()
+        {
+            _series = Builder<Series>.CreateNew()
+                                     .Build();
+
+            _episode = Builder<Episode>.CreateNew()
+                                       .Build();
+
+            _profile = new Profile
+                       {
+                           Name = "Test",
+                           Cutoff = Quality.HDTV720p,
+                           GrabDelay = 1,
+                           Items = new List<ProfileQualityItem>
+                                   {
+                                       new ProfileQualityItem { Allowed = true, Quality = Quality.HDTV720p },
+                                       new ProfileQualityItem { Allowed = true, Quality = Quality.WEBDL720p },
+                                       new ProfileQualityItem { Allowed = true, Quality = Quality.Bluray720p }
+                                   },
+                       };
+
+            _series.Profile = new LazyLoaded<Profile>(_profile);
+
+            _release = Builder<ReleaseInfo>.CreateNew().Build();
+
+            _parsedEpisodeInfo = Builder<ParsedEpisodeInfo>.CreateNew().Build();
+            _parsedEpisodeInfo.Quality = new QualityModel(Quality.HDTV720p);
+
+            _remoteEpisode = new RemoteEpisode();
+            _remoteEpisode.Episodes = new List<Episode>{ _episode };
+            _remoteEpisode.Series = _series;
+            _remoteEpisode.ParsedEpisodeInfo = _parsedEpisodeInfo;
+            _remoteEpisode.Release = _release;
+            
+            _temporarilyRejected = new DownloadDecision(_remoteEpisode, new Rejection("Temp Rejected", RejectionType.Temporary));
+
+            Mocker.GetMock<IPendingReleaseRepository>()
+                  .Setup(s => s.All())
+                  .Returns(new List<PendingRelease>());
+
+            Mocker.GetMock<ISeriesService>()
+                  .Setup(s => s.GetSeries(It.IsAny<Int32>()))
+                  .Returns(_series);
+
+            Mocker.GetMock<IParsingService>()
+                  .Setup(s => s.GetEpisodes(It.IsAny<ParsedEpisodeInfo>(), _series, true, null))
+                  .Returns(new List<Episode> {_episode});
+
+            Mocker.GetMock<IPrioritizeDownloadDecision>()
+                  .Setup(s => s.PrioritizeDecisions(It.IsAny<List<DownloadDecision>>()))
+                  .Returns((List<DownloadDecision> d) => d);
+        }
+
+        private void GivenHeldRelease(String title, String indexer, DateTime publishDate)
+        {
+            var release = _release.JsonClone();
+            release.Indexer = indexer;
+            release.PublishDate = publishDate;
+
+
+            var heldReleases = Builder<PendingRelease>.CreateListOfSize(1)
+                                                   .All()
+                                                   .With(h => h.SeriesId = _series.Id)
+                                                   .With(h => h.Title = title)
+                                                   .With(h => h.Release = release)
+                                                   .Build();
+
+            Mocker.GetMock<IPendingReleaseRepository>()
+                  .Setup(s => s.All())
+                  .Returns(heldReleases);
+        }
+
+        [Test]
+        public void should_remove_if_it_is_the_same_release_from_the_same_indexer()
+        {
+            GivenHeldRelease(_release.Title, _release.Indexer, _release.PublishDate);
+
+            Subject.RemoveRejected(new List<DownloadDecision> { _temporarilyRejected });
+
+            VerifyDelete();
+        }
+
+        [Test]
+        public void should_not_remove_if_title_is_different()
+        {
+            GivenHeldRelease(_release.Title + "-RP", _release.Indexer, _release.PublishDate);
+
+            Subject.RemoveRejected(new List<DownloadDecision> { _temporarilyRejected });
+
+            VerifyNoDelete();
+        }
+
+        [Test]
+        public void should_not_remove_if_indexer_is_different()
+        {
+            GivenHeldRelease(_release.Title, "AnotherIndexer", _release.PublishDate);
+
+            Subject.RemoveRejected(new List<DownloadDecision> { _temporarilyRejected });
+
+            VerifyNoDelete();
+        }
+
+        [Test]
+        public void should_not_remove_if_publish_date_is_different()
+        {
+            GivenHeldRelease(_release.Title, _release.Indexer, _release.PublishDate.AddHours(1));
+
+            Subject.RemoveRejected(new List<DownloadDecision> { _temporarilyRejected });
+
+            VerifyNoDelete();
+        }
+
+        private void VerifyDelete()
+        {
+            Mocker.GetMock<IPendingReleaseRepository>()
+                .Verify(v => v.Delete(It.IsAny<PendingRelease>()), Times.Once());
+        }
+
+        private void VerifyNoDelete()
+        {
+            Mocker.GetMock<IPendingReleaseRepository>()
+                .Verify(v => v.Delete(It.IsAny<PendingRelease>()), Times.Never());
+        }
+    }
+}