Improved PushBullet implementation (v2 API, multiple devices, channels)

New: PushBullet supports multiple devices New: PushBullet channels Closes #641
2026-04-24 22:35:39 -04:00 · 2015-06-28 01:50:19 -07:00
parent 120be567d3
commit 77e9493ccf
12 changed files with 312 additions and 37 deletions
@@ -0,0 +1,90 @@
+using System.Linq;
+using FluentAssertions;
+using NUnit.Framework;
+using NzbDrone.Common.Serializer;
+using NzbDrone.Core.Notifications;
+using NzbDrone.Core.Notifications.PushBullet;
+using NzbDrone.Core.Notifications.Pushover;
+using NzbDrone.Core.Test.Framework;
+namespace NzbDrone.Core.Test.Datastore.Migration
+{
+    [TestFixture]
+    public class pushbullet_device_idsFixture : MigrationTest<Core.Datastore.Migration.pushbullet_device_ids>
+    {
+        [Test]
+        public void should_not_fail_if_no_pushbullet()
+        {
+            WithTestDb(c =>
+            {
+                c.Insert.IntoTable("Notifications").Row(new 
+                {
+                    OnGrab = false,
+                    OnDownload = false,
+                    OnUpgrade = false,
+                    Name = "Pushover",
+                    Implementation = "Pushover",
+                    Settings = new PushoverSettings().ToJson(),
+                    ConfigContract = "PushoverSettings"
+                });
+            });
+
+            var items = Mocker.Resolve<NotificationRepository>().All();
+
+            items.Should().HaveCount(1);
+        }
+
+        [Test]
+        public void should_not_fail_if_deviceId_is_not_set()
+        {
+            WithTestDb(c =>
+            {
+                c.Insert.IntoTable("Notifications").Row(new
+                {
+                    OnGrab = false,
+                    OnDownload = false,
+                    OnUpgrade = false,
+                    Name = "PushBullet",
+                    Implementation = "PushBullet",
+                    Settings = new
+                    {
+                        ApiKey = "my_api_key",
+                    }.ToJson(),
+                    ConfigContract = "PushBulletSettings"
+                });
+            });
+
+            var items = Mocker.Resolve<NotificationRepository>().All();
+
+            items.Should().HaveCount(1);
+        }
+
+        [Test]
+        public void should_add_deviceIds_setting_matching_deviceId()
+        {
+            var deviceId = "device_id";
+
+            WithTestDb(c =>
+            {
+                c.Insert.IntoTable("Notifications").Row(new
+                {
+                    OnGrab = false,
+                    OnDownload = false,
+                    OnUpgrade = false,
+                    Name = "PushBullet",
+                    Implementation = "PushBullet",
+                    Settings = new 
+                    {
+                        ApiKey = "my_api_key",
+                        DeviceId = deviceId
+                    }.ToJson(),
+                    ConfigContract = "PushBulletSettings"
+                });
+            });
+
+            var items = Mocker.Resolve<NotificationRepository>().All();
+
+            items.Should().HaveCount(1);
+            items.First().Settings.As<PushBulletSettings>().DeviceIds.Should().Be(deviceId);
+        }
+    }
+}