tedkulp/Readarr
1
0
Fork 0
mirror of https://github.com/Readarr/Readarr.git synced 2026-04-18 21:34:28 -04:00
Code Issues Projects Releases Wiki Activity

Rework how albums are refreshed/added, add album search route (#190)

Browse Source 
Rework how albums are refreshed/added, add album search route
This commit is contained in:
Qstick
2018-01-28 01:27:33 -05:00
committed by GitHub
parent 6ff5e6337b
commit 5551b2166a
21 changed files with 599 additions and 193 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
src/NzbDrone.Core.Test/MetadataSource/SkyHook/SkyHookProxyFixture.cs
View File

@@ -4,7 +4,6 @@ using System.Linq;
using FluentAssertions;
using NUnit.Framework;
using NzbDrone.Core.Exceptions;
using NzbDrone.Core.MediaCover;
using NzbDrone.Core.MetadataSource.SkyHook;
using NzbDrone.Core.Test.Framework;
using NzbDrone.Core.Music;
@@ -47,6 +46,10 @@ namespace NzbDrone.Core.Test.MetadataSource.SkyHook
Mocker.GetMock<IMetadataProfileService>()
.Setup(s => s.Get(It.IsAny<int>()))
.Returns(_metadataProfile);
Mocker.GetMock<IMetadataProfileService>()
.Setup(s => s.Exists(It.IsAny<int>()))
.Returns(true);
}
[TestCase("f59c5520-5f46-4d2c-b2c4-822eabf53419", "Linkin Park")]
@@ -60,11 +63,53 @@ namespace NzbDrone.Core.Test.MetadataSource.SkyHook
details.Item1.Name.Should().Be(name);
}
[TestCase("12fa3845-7c62-36e5-a8da-8be137155a72", null, "Hysteria")]
public void should_be_able_to_get_album_detail(string mbId, string release, string name)
{
var details = Subject.GetAlbumInfo(mbId, release);
ValidateAlbums(new List<Album> {details.Item1});
details.Item1.Title.Should().Be(name);
}
[TestCase("12fa3845-7c62-36e5-a8da-8be137155a72", "3c186b52-ca73-46a3-a8e6-04559bfbb581",1, 13, "Hysteria")]
[TestCase("12fa3845-7c62-36e5-a8da-8be137155a72", "dee9ca6f-4f84-4359-82a9-b75a37ffc316",2, 27,"Hysteria")]
public void should_be_able_to_get_album_detail_with_release(string mbId, string release, int mediaCount, int trackCount, string name)
{
var details = Subject.GetAlbumInfo(mbId, release);
ValidateAlbums(new List<Album> { details.Item1 });
details.Item1.Media.Count.Should().Be(mediaCount);
details.Item2.Count.Should().Be(trackCount);
details.Item1.Title.Should().Be(name);
}
[Test]
public void getting_details_of_invalid_artist()
{
Assert.Throws<BadRequestException>(() => Subject.GetArtistInfo("aaaaaa-aaa-aaaa-aaaa", 1));
Assert.Throws<ArtistNotFoundException>(() => Subject.GetArtistInfo("66c66aaa-6e2f-4930-8610-912e24c63ed1", 1));
}
[Test]
public void getting_details_of_invalid_guid_for_artist()
{
Assert.Throws<BadRequestException>(() => Subject.GetArtistInfo("66c66aaa-6e2f-4930-aaaaaa", 1));
}
[Test]
public void getting_details_of_invalid_album()
{
Assert.Throws<AlbumNotFoundException>(() => Subject.GetAlbumInfo("66c66aaa-6e2f-4930-8610-912e24c63ed1",null));
}
[Test]
public void getting_details_of_invalid_guid_for_album()
{
Assert.Throws<BadRequestException>(() => Subject.GetAlbumInfo("66c66aaa-6e2f-4930-aaaaaa", null));
}
private void ValidateArtist(Artist artist)
@@ -75,7 +120,6 @@ namespace NzbDrone.Core.Test.MetadataSource.SkyHook
artist.SortName.Should().Be(Parser.Parser.NormalizeTitle(artist.Name));
artist.Overview.Should().NotBeNullOrWhiteSpace();
artist.Images.Should().NotBeEmpty();
//series.TvRageId.Should().BeGreaterThan(0);
artist.ForeignArtistId.Should().NotBeNullOrWhiteSpace();
}
@@ -83,9 +127,9 @@ namespace NzbDrone.Core.Test.MetadataSource.SkyHook
{
albums.Should().NotBeEmpty();
foreach (var episode in albums)
foreach (var album in albums)
{
ValidateAlbum(episode);
ValidateAlbum(album);
//if atleast one album has title it means parse it working.
albums.Should().Contain(c => !string.IsNullOrWhiteSpace(c.Title));

21
src/NzbDrone.Core.Test/MetadataSource/SkyHook/SkyHookProxySearchFixture.cs
View File

@@ -59,7 +59,7 @@ namespace NzbDrone.Core.Test.MetadataSource.SkyHook
[TestCase("lidarr:f59c5520-5f46-4d2c-b2c4-822eabf53419", "Linkin Park")]
[TestCase("lidarrid:f59c5520-5f46-4d2c-b2c4-822eabf53419", "Linkin Park")]
[TestCase("lidarrid: f59c5520-5f46-4d2c-b2c4-822eabf53419 ", "Linkin Park")]
public void successful_search(string title, string expected)
public void successful_artist_search(string title, string expected)
{
var result = Subject.SearchForNewArtist(title);
@@ -70,13 +70,30 @@ namespace NzbDrone.Core.Test.MetadataSource.SkyHook
ExceptionVerification.IgnoreWarns();
}
[TestCase("Evolve", "Imagine Dragons", "Evolve")]
[TestCase("Hysteria", null, "Hysteria")]
[TestCase("lidarr:d77df681-b779-3d6d-b66a-3bfd15985e3e", null, "Pyromania")]
[TestCase("lidarr: d77df681-b779-3d6d-b66a-3bfd15985e3e", null, "Pyromania")]
[TestCase("lidarrid:d77df681-b779-3d6d-b66a-3bfd15985e3e", null, "Pyromania")]
public void successful_album_search(string title, string artist, string expected)
{
var result = Subject.SearchForNewAlbum(title, artist);
result.Should().NotBeEmpty();
result[0].Title.Should().Be(expected);
ExceptionVerification.IgnoreWarns();
}
[TestCase("lidarrid:")]
[TestCase("lidarrid: 99999999999999999999")]
[TestCase("lidarrid: 0")]
[TestCase("lidarrid: -12")]
[TestCase("lidarrid:289578")]
[TestCase("adjalkwdjkalwdjklawjdlKAJD;EF")]
public void no_search_result(string term)
public void no_artist_search_result(string term)
{
var result = Subject.SearchForNewArtist(term);
result.Should().BeEmpty();