Tests added

Series metadata will be created when series info is refreshed (and on
add)

NzbDrone.Core.Test/NzbDrone.Core.Test.csproj

@@ -114,6 +114,8 @@
     <Compile Include="ProviderTests\AnalyticsProviderTests\AnalyticsProviderFixture.cs" />
     <Compile Include="ProviderTests\ConfigProviderTests\ConfigCachingFixture.cs" />
     <Compile Include="ProviderTests\BannerProviderTest.cs" />
+    <Compile Include="ProviderTests\Metadata\Xbmc_ForEpisodeFile_Fixture.cs" />
+    <Compile Include="ProviderTests\Metadata\Xbmc_ForSeries_Fixture.cs" />
     <Compile Include="ProviderTests\SearchHistoryProviderTest.cs" />
     <Compile Include="ProviderTests\PlexProviderTest.cs" />
     <Compile Include="ProviderTests\SeasonProviderTest.cs" />

NzbDrone.Core.Test/NzbDrone.Core.Test.ncrunchproject

@@ -0,0 +1,19 @@
+<ProjectConfiguration>
+  <CopyReferencedAssembliesToWorkspace>false</CopyReferencedAssembliesToWorkspace>
+  <ConsiderInconclusiveTestsAsPassing>false</ConsiderInconclusiveTestsAsPassing>
+  <PreloadReferencedAssemblies>false</PreloadReferencedAssemblies>
+  <AllowDynamicCodeContractChecking>true</AllowDynamicCodeContractChecking>
+  <AllowStaticCodeContractChecking>false</AllowStaticCodeContractChecking>
+  <IgnoreThisComponentCompletely>false</IgnoreThisComponentCompletely>
+  <RunPreBuildEvents>false</RunPreBuildEvents>
+  <RunPostBuildEvents>false</RunPostBuildEvents>
+  <PreviouslyBuiltSuccessfully>true</PreviouslyBuiltSuccessfully>
+  <InstrumentAssembly>true</InstrumentAssembly>
+  <PreventSigningOfAssembly>false</PreventSigningOfAssembly>
+  <AnalyseExecutionTimes>true</AnalyseExecutionTimes>
+  <IncludeStaticReferencesInWorkspace>true</IncludeStaticReferencesInWorkspace>
+  <DefaultTestTimeout>60000</DefaultTestTimeout>
+  <UseBuildConfiguration />
+  <ProxyProcessPath />
+  <UseCPUArchitecture>AutoDetect</UseCPUArchitecture>
+</ProjectConfiguration>

NzbDrone.Core.Test/ProviderTests/EpisodeProviderTest.cs

@@ -172,7 +172,7 @@ namespace NzbDrone.Core.Test.ProviderTests
             Db.Insert(fakeSeries);
 
             Mocker.GetMock<TvDbProvider>()
-                .Setup(c => c.GetSeries(seriesId, true))
+                .Setup(c => c.GetSeries(seriesId, true, false))
                 .Returns(fakeEpisodes);
 
             //Act
@@ -207,7 +207,7 @@ namespace NzbDrone.Core.Test.ProviderTests
             Db.Insert(fakeSeries);
 
             Mocker.GetMock<TvDbProvider>()
-                .Setup(c => c.GetSeries(seriesId, true))
+                .Setup(c => c.GetSeries(seriesId, true, false))
                 .Returns(fakeEpisodes);
 
 
@@ -248,7 +248,7 @@ namespace NzbDrone.Core.Test.ProviderTests
             Db.Insert(fakeEpisode);
 
             Mocker.GetMock<TvDbProvider>()
-                .Setup(c => c.GetSeries(seriesId, true))
+                .Setup(c => c.GetSeries(seriesId, true, false))
                 .Returns(fakeTvDbEpisodes);
 
             //Act
@@ -285,7 +285,7 @@ namespace NzbDrone.Core.Test.ProviderTests
             Db.Insert(fakeSeries);
 
             Mocker.GetMock<TvDbProvider>()
-                .Setup(c => c.GetSeries(seriesId, true))
+                .Setup(c => c.GetSeries(seriesId, true, false))
                 .Returns(fakeEpisodes);
 
 
@@ -324,7 +324,7 @@ namespace NzbDrone.Core.Test.ProviderTests
             Db.Insert(fakeSeries);
 
             Mocker.GetMock<TvDbProvider>()
-                .Setup(c => c.GetSeries(seriesId, true))
+                .Setup(c => c.GetSeries(seriesId, true, false))
                 .Returns(fakeEpisodes);
 
 
@@ -362,7 +362,7 @@ namespace NzbDrone.Core.Test.ProviderTests
             Db.Insert(fakeSeries);
 
             Mocker.GetMock<TvDbProvider>()
-                .Setup(c => c.GetSeries(seriesId, true))
+                .Setup(c => c.GetSeries(seriesId, true, false))
                 .Returns(fakeEpisodes);
 
 
@@ -395,7 +395,7 @@ namespace NzbDrone.Core.Test.ProviderTests
             Db.Insert(fakeSeries);
 
             Mocker.GetMock<TvDbProvider>()
-                .Setup(c => c.GetSeries(seriesId, true))
+                .Setup(c => c.GetSeries(seriesId, true, false))
                 .Returns(fakeEpisodes);
 
 
@@ -428,7 +428,7 @@ namespace NzbDrone.Core.Test.ProviderTests
             Db.Insert(fakeSeries);
 
             Mocker.GetMock<TvDbProvider>()
-                .Setup(c => c.GetSeries(seriesId, true))
+                .Setup(c => c.GetSeries(seriesId, true, false))
                 .Returns(fakeEpisodes);
 
 
@@ -463,7 +463,7 @@ namespace NzbDrone.Core.Test.ProviderTests
             Db.Insert(fakeSeries);
 
             Mocker.GetMock<TvDbProvider>()
-                .Setup(c => c.GetSeries(seriesId, true))
+                .Setup(c => c.GetSeries(seriesId, true, false))
                 .Returns(fakeEpisodes);
 
             Mocker.GetMock<SeasonProvider>()
@@ -493,7 +493,7 @@ namespace NzbDrone.Core.Test.ProviderTests
             var currentEpisodes = new List<Episode>();
 
             Mocker.GetMock<TvDbProvider>(MockBehavior.Strict)
-                .Setup(c => c.GetSeries(seriesId, true))
+                .Setup(c => c.GetSeries(seriesId, true, false))
                 .Returns(tvdbSeries);
 
             Mocker.GetMock<IDatabase>()
@@ -528,7 +528,7 @@ namespace NzbDrone.Core.Test.ProviderTests
             }
 
             Mocker.GetMock<TvDbProvider>(MockBehavior.Strict)
-                .Setup(c => c.GetSeries(seriesId, true))
+                .Setup(c => c.GetSeries(seriesId, true, false))
                 .Returns(tvdbSeries);
 
             Mocker.GetMock<IDatabase>()
@@ -565,7 +565,7 @@ namespace NzbDrone.Core.Test.ProviderTests
                 .Returns(fakeEpisodeList);
 
             Mocker.GetMock<TvDbProvider>()
-                .Setup(c => c.GetSeries(seriesId, true))
+                .Setup(c => c.GetSeries(seriesId, true, false))
                 .Returns(fakeTvDbResult);
 
             //Act
@@ -602,7 +602,7 @@ namespace NzbDrone.Core.Test.ProviderTests
             var fakeSeries = Builder<Series>.CreateNew().With(c => c.SeriesId = seriesId).Build();
 
             Mocker.GetMock<TvDbProvider>(MockBehavior.Strict)
-                .Setup(c => c.GetSeries(seriesId, true))
+                .Setup(c => c.GetSeries(seriesId, true, false))
                 .Returns(tvdbSeries);
 
             Mocker.GetMock<IDatabase>()
@@ -634,7 +634,7 @@ namespace NzbDrone.Core.Test.ProviderTests
             }
 
             Mocker.GetMock<TvDbProvider>(MockBehavior.Strict)
-                .Setup(c => c.GetSeries(seriesId, true))
+                .Setup(c => c.GetSeries(seriesId, true, false))
                 .Returns(tvdbSeries);
 
             var updatedEpisodes = new List<Episode>();
@@ -695,7 +695,7 @@ namespace NzbDrone.Core.Test.ProviderTests
             Db.Insert(fakeEpisode);
 
             Mocker.GetMock<TvDbProvider>()
-                .Setup(c => c.GetSeries(seriesId, true))
+                .Setup(c => c.GetSeries(seriesId, true, false))
                 .Returns(tvdbSeries);
 
             Mocker.GetMock<SeasonProvider>()
@@ -1407,7 +1407,7 @@ namespace NzbDrone.Core.Test.ProviderTests
             Db.Insert(fakeSeries);
 
             Mocker.GetMock<TvDbProvider>()
-                .Setup(c => c.GetSeries(seriesId, true))
+                .Setup(c => c.GetSeries(seriesId, true, false))
                 .Returns(tvdbSeries);
 
             //Act

NzbDrone.Core.Test/ProviderTests/Metadata/Xbmc_ForEpisodeFile_Fixture.cs

@@ -0,0 +1,153 @@
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+using System.Net;
+using FizzWare.NBuilder;
+using FluentAssertions;
+using Moq;
+using NUnit.Framework;
+using NzbDrone.Common;
+using NzbDrone.Core.Model.Notification;
+using NzbDrone.Core.Providers;
+using NzbDrone.Core.Providers.Core;
+using NzbDrone.Core.Providers.Metadata;
+using NzbDrone.Core.Repository;
+using NzbDrone.Core.Repository.Quality;
+using NzbDrone.Core.Test.Framework;
+using NzbDrone.Test.Common.AutoMoq;
+using NzbDrone.Test.Common;
+using TvdbLib.Data;
+using TvdbLib.Data.Banner;
+
+namespace NzbDrone.Core.Test.ProviderTests.Metadata
+{
+    [TestFixture]
+    // ReSharper disable InconsistentNaming
+    public class Xbmc_ForEpisoddeFile_Fixture : CoreTest
+    {
+        private Series series;
+        private EpisodeFile episodeFile;
+        private TvdbSeries tvdbSeries;
+
+        [SetUp]
+        public void Setup()
+        {
+            WithTempAsAppPath();
+
+            series = Builder<Series>
+                    .CreateNew()
+                    .With(s => s.SeriesId == 79488)
+                    .With(s => s.Title == "30 Rock")
+                    .Build();
+
+            episodeFile = Builder<EpisodeFile>.CreateNew()
+                    .With(f => f.SeriesId = 79488)
+                    .With(f => f.SeasonNumber = 1)
+                    .With(f => f.Path = @"C:\Test\30 Rock\Season 01\30 Rock - S01E01 - Pilot.avi")
+                    .Build();
+
+            var tvdbEpisodes = Builder<TvdbEpisode>.CreateListOfSize(2)
+                    .All()
+                    .With(e => e.SeriesId = 79488)
+                    .With(e => e.SeasonNumber = 1)
+                    .With(e => e.Directors = new List<string>{ "Fake Director" })
+                    .With(e => e.Writer = new List<string>{ "Fake Writer" })
+                    .With(e => e.GuestStars = new List<string> { "Guest Star 1", "Guest Star 2", "Guest Star 3", "" })
+                    .Build();
+
+            var seasonBanners = Builder<TvdbSeasonBanner>
+                    .CreateListOfSize(4)
+                    .TheFirst(2)
+                    .With(b => b.Season = 1)
+                    .TheLast(2)
+                    .With(b => b.Season = 2)
+                    .TheFirst(1)
+                    .With(b => b.BannerType = TvdbSeasonBanner.Type.season)
+                    .With(b => b.BannerPath = "seasons/79488-1-1.jpg")
+                    .TheNext(2)
+                    .With(b => b.BannerType = TvdbSeasonBanner.Type.seasonwide)
+                    .With(b => b.BannerPath = "banners/seasons/79488-test.jpg")
+                    .TheLast(1)
+                    .With(b => b.BannerType = TvdbSeasonBanner.Type.season)
+                    .With(b => b.BannerPath = "seasons/79488-2-1.jpg")
+                    .Build();
+
+            var seriesActors = Builder<TvdbActor>
+                    .CreateListOfSize(5)
+                    .Build();
+
+            tvdbSeries = Builder<TvdbSeries>
+                    .CreateNew()
+                    .With(s => s.Id = 79488)
+                    .With(s => s.SeriesName = "30 Rock")
+                    .With(s => s.TvdbActors = seriesActors.ToList())
+                    .With(s => s.Episodes = tvdbEpisodes.ToList())
+                    .Build();
+
+            tvdbSeries.Banners.AddRange(seasonBanners);
+        }
+
+        private void WithUseBanners()
+        {
+            Mocker.GetMock<ConfigProvider>().SetupGet(s => s.MetadataUseBanners).Returns(true);
+        }
+
+        private void WithSingleEpisodeFile()
+        {
+            var episode = Builder<Episode>.CreateNew()
+                    .With(e => e.SeasonNumber = 1)
+                    .With(e => e.SeriesId = 79488)
+                    .With(e => e.EpisodeNumber = 1)
+                    .Build();
+
+            Mocker.GetMock<EpisodeProvider>()
+                        .Setup(s => s.GetEpisodesByFileId(episodeFile.EpisodeFileId))
+                        .Returns(new List<Episode> { episode });
+        }
+
+        private void WithMultiEpisodeFile()
+        {
+            var episodes = Builder<Episode>.CreateListOfSize(2)
+                    .All()
+                    .With(e => e.SeriesId = 79488)
+                    .With(e => e.SeasonNumber = 1)
+                    .Build();
+
+            Mocker.GetMock<EpisodeProvider>()
+                        .Setup(s => s.GetEpisodesByFileId(episodeFile.EpisodeFileId))
+                        .Returns(episodes.ToList());
+        }
+
+        [Test]
+        public void should_not_blowup()
+        {
+            WithSingleEpisodeFile();
+            Mocker.Resolve<Xbmc>().ForEpisodeFile(episodeFile, tvdbSeries);
+        }
+
+        [Test]
+        public void should_call_diskprovider_writeAllText_once_for_single_episode()
+        {
+            WithSingleEpisodeFile();
+            Mocker.Resolve<Xbmc>().ForEpisodeFile(episodeFile, tvdbSeries);
+            Mocker.GetMock<DiskProvider>().Verify(v => v.WriteAllText(episodeFile.Path.Replace("avi", "nfo"), It.IsAny<string>()), Times.Once());
+        }
+
+        [Test]
+        public void should_call_diskprovider_writeAllText_once_for_multi_episode()
+        {
+            WithMultiEpisodeFile();
+            Mocker.Resolve<Xbmc>().ForEpisodeFile(episodeFile, tvdbSeries);
+            Mocker.GetMock<DiskProvider>().Verify(v => v.WriteAllText(episodeFile.Path.Replace("avi", "nfo"), It.IsAny<string>()), Times.Once());
+        }
+
+        [Test]
+        public void should_download_thumbnail_when_thumbnail_path_is_not_null()
+        {
+            WithSingleEpisodeFile();
+            Mocker.Resolve<Xbmc>().ForEpisodeFile(episodeFile, tvdbSeries);
+            Mocker.GetMock<BannerProvider>().Verify(v => v.Download(tvdbSeries.Episodes.First().BannerPath, episodeFile.Path.Replace("avi", "tbn")), Times.Once());
+        }
+    }
+}

NzbDrone.Core.Test/ProviderTests/Metadata/Xbmc_ForSeries_Fixture.cs

@@ -0,0 +1,128 @@
+using System;
+using System.IO;
+using System.Linq;
+using System.Net;
+using FizzWare.NBuilder;
+using FluentAssertions;
+using Moq;
+using NUnit.Framework;
+using NzbDrone.Common;
+using NzbDrone.Core.Model.Notification;
+using NzbDrone.Core.Providers;
+using NzbDrone.Core.Providers.Core;
+using NzbDrone.Core.Providers.Metadata;
+using NzbDrone.Core.Repository;
+using NzbDrone.Core.Repository.Quality;
+using NzbDrone.Core.Test.Framework;
+using NzbDrone.Test.Common.AutoMoq;
+using NzbDrone.Test.Common;
+using TvdbLib.Data;
+using TvdbLib.Data.Banner;
+
+namespace NzbDrone.Core.Test.ProviderTests.Metadata
+{
+    [TestFixture]
+    // ReSharper disable InconsistentNaming
+    public class Xbmc_ForSeries_Fixture : CoreTest
+    {
+        private Series series;
+        private TvdbSeries tvdbSeries;
+
+        [SetUp]
+        public void Setup()
+        {
+            WithTempAsAppPath();
+
+            series = Builder<Series>
+                    .CreateNew()
+                    .With(s => s.SeriesId == 79488)
+                    .With(s => s.Title == "30 Rock")
+                    .Build();
+
+            var seasonBanners = Builder<TvdbSeasonBanner>
+                    .CreateListOfSize(4)
+                    .TheFirst(2)
+                    .With(b => b.Season = 1)
+                    .TheLast(2)
+                    .With(b => b.Season = 2)
+                    .TheFirst(1)
+                    .With(b => b.BannerType = TvdbSeasonBanner.Type.season)
+                    .With(b => b.BannerPath = "seasons/79488-1-1.jpg")
+                    .TheNext(2)
+                    .With(b => b.BannerType = TvdbSeasonBanner.Type.seasonwide)
+                    .With(b => b.BannerPath = "banners/seasons/79488-test.jpg")
+                    .TheLast(1)
+                    .With(b => b.BannerType = TvdbSeasonBanner.Type.season)
+                    .With(b => b.BannerPath = "seasons/79488-2-1.jpg")
+                    .Build();
+
+            var seriesActors = Builder<TvdbActor>
+                    .CreateListOfSize(5)
+                    .Build();
+
+            tvdbSeries = Builder<TvdbSeries>
+                    .CreateNew()
+                    .With(s => s.Id = 79488)
+                    .With(s => s.SeriesName = "30 Rock")
+                    .With(s => s.TvdbActors = seriesActors.ToList())
+                    .Build();
+
+            tvdbSeries.Banners.AddRange(seasonBanners);
+        }
+
+        private void WithUseBanners()
+        {
+            Mocker.GetMock<ConfigProvider>().SetupGet(s => s.MetadataUseBanners).Returns(true);
+        }
+
+        [Test]
+        public void should_not_blowup()
+        {
+            Mocker.Resolve<Xbmc>().ForSeries(series, tvdbSeries);
+        }
+
+        [Test]
+        public void should_call_diskprovider_writeAllText()
+        {
+            Mocker.Resolve<Xbmc>().ForSeries(series, tvdbSeries);
+            Mocker.GetMock<DiskProvider>().Verify(v => v.WriteAllText(Path.Combine(series.Path, "tvshow.nfo"), It.IsAny<string>()), Times.Once());
+        }
+
+        [Test]
+        public void should_download_fanart()
+        {
+            Mocker.Resolve<Xbmc>().ForSeries(series, tvdbSeries);
+            Mocker.GetMock<BannerProvider>().Verify(v => v.Download(tvdbSeries.FanartPath, Path.Combine(series.Path, "fanart.jpg")), Times.Once());
+        }
+
+        [Test]
+        public void should_download_poster_when_useBanners_is_false()
+        {
+            Mocker.Resolve<Xbmc>().ForSeries(series, tvdbSeries);
+            Mocker.GetMock<BannerProvider>().Verify(v => v.Download(tvdbSeries.PosterPath, Path.Combine(series.Path, "folder.jpg")), Times.Once());
+        }
+
+        [Test]
+        public void should_download_banner_when_useBanners_is_true()
+        {
+            WithUseBanners();
+            Mocker.Resolve<Xbmc>().ForSeries(series, tvdbSeries);
+            Mocker.GetMock<BannerProvider>().Verify(v => v.Download(tvdbSeries.BannerPath, Path.Combine(series.Path, "folder.jpg")), Times.Once());
+        }
+
+        [Test]
+        public void should_download_season_poster_when_useBanners_is_false()
+        {
+            Mocker.Resolve<Xbmc>().ForSeries(series, tvdbSeries);
+            Mocker.GetMock<BannerProvider>().Verify(v => v.Download(It.Is<string>(s => !s.Contains("banners")), It.IsRegex(@"season\d{2}\.tbn")), Times.Exactly(2));
+        }
+
+        [Test]
+        public void should_download_season_banner_when_useBanners_is_true()
+        {
+            WithUseBanners();
+            Mocker.Resolve<Xbmc>().ForSeries(series, tvdbSeries);
+            Mocker.GetMock<BannerProvider>().Verify(v => v.Download(It.Is<string>(s => s.Contains("banners")), It.IsRegex(@"season\d{2}\.tbn")), Times.Exactly(2));
+        }
+    }
+}