Episode searching now stores the results of the tests.

NzbDrone.Core.Test/JobTests/SeasonSearchJobTest.cs

@@ -6,9 +6,11 @@ using FizzWare.NBuilder;
 using Moq;
 using NUnit.Framework;
 using NzbDrone.Core.Jobs;
+using NzbDrone.Core.Model;
 using NzbDrone.Core.Model.Notification;
 using NzbDrone.Core.Providers;
 using NzbDrone.Core.Repository;
+using NzbDrone.Core.Repository.Search;
 using NzbDrone.Core.Test.Framework;
 using NzbDrone.Test.Common.AutoMoq;
 
@@ -39,10 +41,16 @@ namespace NzbDrone.Core.Test.JobTests
         [Test]
         public void SeasonSearch_partial_season_success()
         {
+            var resultItems = Builder<SearchResultItem>.CreateListOfSize(5)
+                .All()
+                .With(e => e.SearchError = ReportRejectionType.None)
+                .With(e => e.Success = true)
+                .Build();
+
             var episodes = Builder<Episode>.CreateListOfSize(5)
                 .All()
-                .With(e => e.SeriesId = 1)
                 .With(e => e.SeasonNumber = 1)
+                .With(e => e.SeriesId = 5)
                 .Build();
 
             var notification = new ProgressNotification("Season Search");
@@ -55,7 +63,7 @@ namespace NzbDrone.Core.Test.JobTests
 
             Mocker.GetMock<SearchProvider>()
                 .Setup(c => c.PartialSeasonSearch(notification, 1, 1))
-                .Returns(episodes.Select(e => e.EpisodeNumber).ToList());
+                .Returns(resultItems.ToList());
 
             //Act
             Mocker.Resolve<SeasonSearchJob>().Start(notification, 1, 1);
@@ -88,7 +96,7 @@ namespace NzbDrone.Core.Test.JobTests
 
             Mocker.GetMock<SearchProvider>()
                 .Setup(c => c.PartialSeasonSearch(notification, 1, 1))
-                .Returns(new List<int>{1});
+                .Returns(new List<SearchResultItem>{ new SearchResultItem{ Success = true }});
 
             //Act
             Mocker.Resolve<SeasonSearchJob>().Start(notification, 1, 1);
@@ -122,7 +130,7 @@ namespace NzbDrone.Core.Test.JobTests
 
             Mocker.GetMock<SearchProvider>()
                 .Setup(c => c.PartialSeasonSearch(notification, 1, 1))
-                .Returns(new List<int>());
+                .Returns(new List<SearchResultItem> { new SearchResultItem { Success = false, SearchError = ReportRejectionType.Size} });
 
 
             //Act

NzbDrone.Core.Test/ProviderTests/DecisionEngineTests/AllowedDownloadSpecificationFixture.cs

@@ -88,42 +88,42 @@ namespace NzbDrone.Core.Test.ProviderTests.DecisionEngineTests
         [Test]
         public void should_be_allowed_if_all_conditions_are_met()
         {
-            spec.IsSatisfiedBy(parseResult).Should().BeTrue();
+            spec.IsSatisfiedBy(parseResult).Should().Be(ReportRejectionType.None);
         }
 
         [Test]
         public void should_not_be_allowed_if_profile_is_not_allowed()
         {
             WithProfileNotAllowed();
-            spec.IsSatisfiedBy(parseResult).Should().BeFalse();
+            spec.IsSatisfiedBy(parseResult).Should().Be(ReportRejectionType.QualityNotWanted);
         }
 
         [Test]
         public void should_not_be_allowed_if_size_is_not_allowed()
         {
             WithNotAcceptableSize();
-            spec.IsSatisfiedBy(parseResult).Should().BeFalse();
+            spec.IsSatisfiedBy(parseResult).Should().Be(ReportRejectionType.Size);
         }
 
         [Test]
         public void should_not_be_allowed_if_disk_is_not_upgrade()
         {
             WithNoDiskUpgrade();
-            spec.IsSatisfiedBy(parseResult).Should().BeFalse();
+            spec.IsSatisfiedBy(parseResult).Should().Be(ReportRejectionType.ExistingQualityIsEqualOrBetter);
         }
 
         [Test]
         public void should_not_be_allowed_if_episode_is_already_in_queue()
         {
             WithEpisodeAlreadyInQueue();
-            spec.IsSatisfiedBy(parseResult).Should().BeFalse();
+            spec.IsSatisfiedBy(parseResult).Should().Be(ReportRejectionType.AlreadyInQueue);
         }
 
         [Test]
         public void should_not_be_allowed_if_report_is_over_retention()
         {
             WithOverRetention();
-            spec.IsSatisfiedBy(parseResult).Should().BeFalse();
+            spec.IsSatisfiedBy(parseResult).Should().Be(ReportRejectionType.Retention);
         }
 
         [Test]
@@ -134,7 +134,7 @@ namespace NzbDrone.Core.Test.ProviderTests.DecisionEngineTests
             WithProfileNotAllowed();
             WithOverRetention();
 
-            spec.IsSatisfiedBy(parseResult).Should().BeFalse();
+            spec.IsSatisfiedBy(parseResult).Should().Be(ReportRejectionType.QualityNotWanted);
         }
     }
 }

NzbDrone.Core.Test/ProviderTests/SearchProviderTests/ProcessDailySearchResultsFixture.cs

@@ -77,14 +77,14 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
         {
             Mocker.GetMock<AllowedDownloadSpecification>()
                 .Setup(s => s.IsSatisfiedBy(It.IsAny<EpisodeParseResult>()))
-                .Returns(true);
+                .Returns(ReportRejectionType.None);
         }
 
         private void WithQualityNotNeeded()
         {
             Mocker.GetMock<AllowedDownloadSpecification>()
                 .Setup(s => s.IsSatisfiedBy(It.IsAny<EpisodeParseResult>()))
-                .Returns(false);
+                .Returns(ReportRejectionType.ExistingQualityIsEqualOrBetter);
         }
 
         [Test]
@@ -103,13 +103,13 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
 
             Mocker.GetMock<AllowedDownloadSpecification>()
                 .Setup(s => s.IsSatisfiedBy(It.Is<EpisodeParseResult>(d => d.Quality.QualityType == QualityTypes.Bluray1080p)))
-                .Returns(true);
+                .Returns(ReportRejectionType.None);
 
             //Act
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(MockNotification, parseResults, _matchingSeries, DateTime.Today);
 
             //Assert
-            result.Should().BeTrue();
+            result.Should().Contain(n => n.Success);
 
             Mocker.GetMock<AllowedDownloadSpecification>().Verify(c => c.IsSatisfiedBy(It.IsAny<EpisodeParseResult>()),
                                                        Times.Once());
@@ -133,7 +133,7 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(MockNotification, parseResults, _matchingSeries, DateTime.Today);
 
             //Assert
-            result.Should().BeFalse();
+            result.Should().NotContain(n => n.Success);
 
             Mocker.GetMock<AllowedDownloadSpecification>().Verify(c => c.IsSatisfiedBy(It.IsAny<EpisodeParseResult>()),
                                                        Times.Exactly(5));
@@ -155,7 +155,7 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(MockNotification, parseResults, _matchingSeries, DateTime.Today);
 
             //Assert
-            result.Should().BeFalse();
+            result.Should().NotContain(n => n.Success);
 
             Mocker.GetMock<DownloadProvider>().Verify(c => c.DownloadReport(It.IsAny<EpisodeParseResult>()),
                                                       Times.Never());
@@ -175,7 +175,7 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(MockNotification, parseResults, _matchingSeries, DateTime.Today);
 
             //Assert
-            result.Should().BeFalse();
+            result.Should().NotContain(n => n.Success);
 
             Mocker.GetMock<DownloadProvider>().Verify(c => c.DownloadReport(It.IsAny<EpisodeParseResult>()),
                                                       Times.Never());
@@ -198,7 +198,7 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(MockNotification, parseResults, _matchingSeries, DateTime.Today);
 
             //Assert
-            result.Should().BeTrue();
+            result.Should().Contain(n => n.Success);
 
             Mocker.GetMock<DownloadProvider>().Verify(c => c.DownloadReport(It.IsAny<EpisodeParseResult>()),
                                                       Times.Once());
@@ -230,7 +230,7 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(MockNotification, parseResults, _matchingSeries, DateTime.Today);
 
             //Assert
-            result.Should().BeTrue();
+            result.Should().Contain(n => n.Success);
 
             Mocker.GetMock<DownloadProvider>().Verify(c => c.DownloadReport(It.IsAny<EpisodeParseResult>()),
                                                       Times.Exactly(2));
@@ -250,7 +250,7 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(MockNotification, parseResults, _matchingSeries, DateTime.Today);
 
             //Assert
-            result.Should().BeFalse();
+            result.Should().NotContain(n => n.Success);
 
             Mocker.GetMock<DownloadProvider>().Verify(c => c.DownloadReport(It.IsAny<EpisodeParseResult>()),
                                                       Times.Never());
@@ -270,7 +270,7 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(MockNotification, parseResults, _matchingSeries, DateTime.Today);
 
             //Assert
-            result.Should().BeFalse();
+            result.Should().NotContain(n => n.Success);
 
             Mocker.GetMock<DownloadProvider>().Verify(c => c.DownloadReport(It.IsAny<EpisodeParseResult>()),
                                                       Times.Never());

NzbDrone.Core.Test/ProviderTests/SearchProviderTests/ProcessSearchResultsFixture.cs

@@ -73,14 +73,14 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
         {
             Mocker.GetMock<AllowedDownloadSpecification>()
                 .Setup(s => s.IsSatisfiedBy(It.IsAny<EpisodeParseResult>()))
-                .Returns(true);
+                .Returns(ReportRejectionType.None);
         }
 
         private void WithQualityNotNeeded()
         {
             Mocker.GetMock<AllowedDownloadSpecification>()
                 .Setup(s => s.IsSatisfiedBy(It.IsAny<EpisodeParseResult>()))
-                .Returns(false);
+                .Returns(ReportRejectionType.ExistingQualityIsEqualOrBetter);
         }
 
         [Test]
@@ -102,14 +102,14 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
 
             Mocker.GetMock<AllowedDownloadSpecification>()
                 .Setup(s => s.IsSatisfiedBy(It.Is<EpisodeParseResult>(d => d.Quality.QualityType == QualityTypes.Bluray1080p)))
-                .Returns(true);
+                .Returns(ReportRejectionType.None);
 
             //Act
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(new ProgressNotification("Test"), parseResults, _matchingSeries, 1, 1);
 
             //Assert
-            result.Should().HaveCount(1);
-            result.First().Should().Be(1);
+            result.Should().HaveCount(parseResults.Count);
+            result.Should().Contain(s => s.Success);
 
             Mocker.GetMock<AllowedDownloadSpecification>().Verify(c => c.IsSatisfiedBy(It.IsAny<EpisodeParseResult>()),
                                                        Times.Once());
@@ -135,13 +135,14 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
             WithSuccessfulDownload();
 
             Mocker.GetMock<AllowedDownloadSpecification>()
-                .Setup(s => s.IsSatisfiedBy(It.IsAny<EpisodeParseResult>())).Returns(true);
+                .Setup(s => s.IsSatisfiedBy(It.IsAny<EpisodeParseResult>())).Returns(ReportRejectionType.None);
 
             //Act
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(MockNotification, parseResults, _matchingSeries, 1, 1);
 
             //Assert
-            result.Should().HaveCount(1);
+            result.Should().HaveCount(parseResults.Count);
+            result.Should().Contain(s => s.Success);
 
 
             Mocker.GetMock<DownloadProvider>().Verify(c => c.DownloadReport(It.Is<EpisodeParseResult>(d => d.Age != 100)), Times.Never());
@@ -165,7 +166,8 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(new ProgressNotification("Test"), parseResults, _matchingSeries, 1, 1);
 
             //Assert
-            result.Should().HaveCount(0);
+            result.Should().HaveCount(parseResults.Count);
+            result.Should().NotContain(s => s.Success);
 
             Mocker.GetMock<AllowedDownloadSpecification>().Verify(c => c.IsSatisfiedBy(It.IsAny<EpisodeParseResult>()),
                                                        Times.Exactly(5));
@@ -188,7 +190,8 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(new ProgressNotification("Test"), parseResults, _matchingSeries, 1, 1);
 
             //Assert
-            result.Should().HaveCount(0);
+            result.Should().HaveCount(parseResults.Count);
+            result.Should().NotContain(s => s.Success);
 
             Mocker.GetMock<DownloadProvider>().Verify(c => c.DownloadReport(It.IsAny<EpisodeParseResult>()),
                                                       Times.Never());
@@ -209,7 +212,8 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(new ProgressNotification("Test"), parseResults, _matchingSeries, 1, 1);
 
             //Assert
-            result.Should().HaveCount(0);
+            result.Should().HaveCount(parseResults.Count);
+            result.Should().NotContain(s => s.Success);
 
             Mocker.GetMock<DownloadProvider>().Verify(c => c.DownloadReport(It.IsAny<EpisodeParseResult>()),
                                                       Times.Never());
@@ -230,7 +234,8 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(new ProgressNotification("Test"), parseResults, _matchingSeries, 1, 1);
 
             //Assert
-            result.Should().HaveCount(0);
+            result.Should().HaveCount(parseResults.Count);
+            result.Should().NotContain(s => s.Success);
 
             Mocker.GetMock<DownloadProvider>().Verify(c => c.DownloadReport(It.IsAny<EpisodeParseResult>()),
                                                       Times.Never());
@@ -251,7 +256,8 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(new ProgressNotification("Test"), parseResults, _matchingSeries, 1, 1);
 
             //Assert
-            result.Should().HaveCount(0);
+            result.Should().HaveCount(parseResults.Count);
+            result.Should().NotContain(s => s.Success);
 
             Mocker.GetMock<DownloadProvider>().Verify(c => c.DownloadReport(It.IsAny<EpisodeParseResult>()),
                                                       Times.Never());
@@ -277,7 +283,8 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(new ProgressNotification("Test"), parseResults, _matchingSeries, 1);
 
             //Assert
-            result.Should().HaveCount(1);
+            result.Should().HaveCount(parseResults.Count);
+            result.Should().Contain(s => s.Success);
 
             Mocker.GetMock<DownloadProvider>().Verify(c => c.DownloadReport(It.IsAny<EpisodeParseResult>()),
                                                       Times.Once());
@@ -310,7 +317,8 @@ namespace NzbDrone.Core.Test.ProviderTests.SearchProviderTests
             var result = Mocker.Resolve<SearchProvider>().ProcessSearchResults(new ProgressNotification("Test"), parseResults, _matchingSeries, 1);
 
             //Assert
-            result.Should().HaveCount(1);
+            result.Should().HaveCount(parseResults.Count);
+            result.Should().Contain(s => s.Success);
 
             Mocker.GetMock<DownloadProvider>().Verify(c => c.DownloadReport(It.IsAny<EpisodeParseResult>()),
                                                       Times.Exactly(2));