From 52c64080f25c05b3a3fbc2bffced48ad72640f36 Mon Sep 17 00:00:00 2001
From: Bogdan <mynameisbogdan@users.noreply.github.com>
Date: Sun, 28 May 2023 02:53:49 +0300
Subject: [PATCH] Enforce rule IDE0005 on build

(cherry picked from commit 6b1e4ef81938d264a2ddc8b626b0502f799aa640)
---
 src/Directory.Build.props                                 | 7 +++++++
 src/NzbDrone.Common/OAuth/OAuthRequest.cs                 | 2 +-
 .../Indexers/TorrentRss/TorrentRssSettingsDetector.cs     | 8 ++++----
 src/NzbDrone.Core/Parser/RomanNumerals/RomanNumeral.cs    | 4 ++--
 4 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/src/Directory.Build.props b/src/Directory.Build.props
index 93347e644e..49ac70fce8 100644
--- a/src/Directory.Build.props
+++ b/src/Directory.Build.props
@@ -30,6 +30,13 @@
     <!-- A test project gets the test sdk packages automatically added -->
     <TestProject>false</TestProject>
     <TestProject Condition="$(MSBuildProjectName.EndsWith('.Test'))">true</TestProject>
+
+    <!-- XML documentation comments are needed to enforce rule IDE0005 on build -->
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
+    <!--
+        CS1591: Missing XML comment for publicly visible type or member 'Type_or_Member'
+    -->
+    <NoWarn>$(NoWarn);CS1591</NoWarn>
   </PropertyGroup>
 
   <PropertyGroup>
diff --git a/src/NzbDrone.Common/OAuth/OAuthRequest.cs b/src/NzbDrone.Common/OAuth/OAuthRequest.cs
index cdf7d9e1f7..ceb9b91173 100644
--- a/src/NzbDrone.Common/OAuth/OAuthRequest.cs
+++ b/src/NzbDrone.Common/OAuth/OAuthRequest.cs
@@ -29,7 +29,7 @@ namespace NzbDrone.Common.OAuth
         public virtual string Version { get; set; }
         public virtual string SessionHandle { get; set; }
 
-        /// <seealso cref="http://oauth.net/core/1.0#request_urls"/>
+        /// <seealso href="http://oauth.net/core/1.0#request_urls"/>
         public virtual string RequestUrl { get; set; }
 
 #if !WINRT
diff --git a/src/NzbDrone.Core/Indexers/TorrentRss/TorrentRssSettingsDetector.cs b/src/NzbDrone.Core/Indexers/TorrentRss/TorrentRssSettingsDetector.cs
index 4947fabcc3..0e13aec355 100644
--- a/src/NzbDrone.Core/Indexers/TorrentRss/TorrentRssSettingsDetector.cs
+++ b/src/NzbDrone.Core/Indexers/TorrentRss/TorrentRssSettingsDetector.cs
@@ -35,11 +35,11 @@ namespace NzbDrone.Core.Indexers.TorrentRss
         /// </summary>
         /// <param name="settings">Indexer Settings to use for Parser</param>
         /// <returns>Parsed Settings or <c>null</c></returns>
-        public TorrentRssIndexerParserSettings Detect(TorrentRssIndexerSettings indexerSettings)
+        public TorrentRssIndexerParserSettings Detect(TorrentRssIndexerSettings settings)
         {
-            _logger.Debug("Evaluating TorrentRss feed '{0}'", indexerSettings.BaseUrl);
+            _logger.Debug("Evaluating TorrentRss feed '{0}'", settings.BaseUrl);
 
-            var requestGenerator = new TorrentRssIndexerRequestGenerator { Settings = indexerSettings };
+            var requestGenerator = new TorrentRssIndexerRequestGenerator { Settings = settings };
             var request = requestGenerator.GetRecentRequests().GetAllTiers().First().First();
 
             HttpResponse httpResponse = null;
@@ -54,7 +54,7 @@ namespace NzbDrone.Core.Indexers.TorrentRss
             }
 
             var indexerResponse = new IndexerResponse(request, httpResponse);
-            return GetParserSettings(indexerResponse, indexerSettings);
+            return GetParserSettings(indexerResponse, settings);
         }
 
         private TorrentRssIndexerParserSettings GetParserSettings(IndexerResponse response, TorrentRssIndexerSettings indexerSettings)
diff --git a/src/NzbDrone.Core/Parser/RomanNumerals/RomanNumeral.cs b/src/NzbDrone.Core/Parser/RomanNumerals/RomanNumeral.cs
index bec6cb7dc8..47564643a2 100644
--- a/src/NzbDrone.Core/Parser/RomanNumerals/RomanNumeral.cs
+++ b/src/NzbDrone.Core/Parser/RomanNumerals/RomanNumeral.cs
@@ -209,7 +209,7 @@ namespace NzbDrone.Core.Parser.RomanNumerals
         /// Returns the Roman numeral that was passed in as either an Arabic numeral
         /// or a Roman numeral.
         /// </summary>
-        /// <returns>A <see cref="System.string" /> representing a Roman Numeral</returns>
+        /// <returns>A <see cref="string" /> representing a Roman Numeral</returns>
         public string ToRomanNumeral()
         {
             return ToString();
@@ -349,7 +349,7 @@ namespace NzbDrone.Core.Parser.RomanNumerals
         /// during creation.
         /// </summary>
         /// <returns>
-        /// A <see cref="System.string" /> that represents a Roman Numeral.
+        /// A <see cref="string" /> that represents a Roman Numeral.
         /// </returns>
         public override string ToString()
         {