tedkulp/PrivateBin
1
0
Fork 0
mirror of https://github.com/PrivateBin/PrivateBin.git synced 2026-03-05 13:30:32 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: added AbstractProxy base class for shortener proxies

Browse Source
This commit is contained in:
Karthik Kasturi
2025-08-15 23:28:44 +01:00
parent 714e455479
commit 4a39a2ad0f
12 changed files with 221 additions and 216 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tst/JsonApiTest.php
View File

@@ -336,6 +336,6 @@ class JsonApiTest extends TestCase
new Controller;
$content = ob_get_contents();
ob_end_clean();
$this->assertStringContainsString('Error calling YOURLS.', $content, 'outputs error correctly');
$this->assertStringContainsString('Error calling proxy.', $content, 'outputs error correctly');
}
}

4
tst/ViewTest.php
View File

@@ -106,8 +106,8 @@ class ViewTest extends TestCase
$content,
$template . ': outputs error correctly'
);
if ($template === 'yourlsproxy' || $template === 'shlinkproxy') {
// yourlsproxy and shlinkproxy templates only display error message
if ($template === 'shortenerproxy') {
// shortenerproxy template only displays error message
continue;
}
$this->assertMatchesRegularExpression(

4
tst/YourlsProxyTest.php
View File

@@ -68,7 +68,7 @@ class YourlsProxyTest extends TestCase
$yourls = new YourlsProxy($this->_conf, 'https://example.com/?foo#bar');
$this->assertTrue($yourls->isError());
$this->assertEquals($yourls->getError(), 'Error parsing YOURLS response.');
$this->assertEquals($yourls->getError(), 'Error calling proxy. Probably a configuration issue, like wrong or missing config keys.');
}
public function testServerError()
@@ -78,6 +78,6 @@ class YourlsProxyTest extends TestCase
$yourls = new YourlsProxy($this->_conf, 'https://example.com/?foo#bar');
$this->assertTrue($yourls->isError());
$this->assertEquals($yourls->getError(), 'Error calling YOURLS. Probably a configuration issue, like wrong or missing "apiurl" or "signature".');
$this->assertEquals($yourls->getError(), 'Error calling proxy. Probably a configuration issue, like wrong or missing config keys.');
}
}